Bug in 0.8.8a maybe?

Post general support questions here that do not specifically fall into the Linux or Windows categories.

Moderators: Developers, Moderators

Post Reply
squeak
Posts: 27
Joined: Fri Nov 26, 2010 5:59 pm

Bug in 0.8.8a maybe?

Post by squeak »

Hi,

Can anyone else confirm if this is a bug in 0.8.8a please. We've just upgraded from 0.8.7i and now when you are adding graphs to a device and select the [Select All] button at the top of the list of "Data Query [SNMP - Interface Statistics]" it selects every item on the whole page (not just that section). This includes all other data queries on the page.

If you use any of the other [Select all] buttons, they all work correctly and select all items only within their own specific query / list. It appears to only be the one at the top of the Interface Statistics section which is broken.

If this is a bug, does anyone have a hack / quick fix for it as it's quite annoying having to manually tick every line :)

Cheers!
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Bug in 0.8.8a maybe?

Post by gandalf »

Just checked, can't confirm
R.
squeak
Posts: 27
Joined: Fri Nov 26, 2010 5:59 pm

Re: Bug in 0.8.8a maybe?

Post by squeak »

Hi - thanks for getting back to me, just in case i'm not explaining the issue properly I've attached an image showing exactly what i'm talking about.

With all the boxes un-ticked, if i click the button with the red arrow it then selects all the items in all the sections on the page, not just interfaces.
Tickbox.JPG
Tickbox.JPG (55.59 KiB) Viewed 1113 times
Incidentally i've tried in both Chrome and Internet Explorer, issue persists in both, and on all devices. I'm often adding new devices and am certain this only started after the upgrade to 0.8.8a.

Is there any other info i can provide from the server itself which could help with this (raw php content etc.?).

Cheers!
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Bug in 0.8.8a maybe?

Post by gandalf »

Are you able to verify this using Firefox? I only want to make sure that it's not a browser issue even if I can't reproduce this right now
R.
squeak
Posts: 27
Joined: Fri Nov 26, 2010 5:59 pm

Re: Bug in 0.8.8a maybe?

Post by squeak »

Hi - yup, it's the same in Firefox. If it helps i can PM you a login to it?

All the best,
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Bug in 0.8.8a maybe?

Post by gandalf »

squeak wrote:Hi - yup, it's the same in Firefox. If it helps i can PM you a login to it?

All the best,
Only, when cli login is available. That's a quite tricky debug session, that would be required here. And Firebug would help as well.
R.
User avatar
Tolaris
Posts: 17
Joined: Mon Nov 15, 2010 3:46 pm
Location: London, UK
Contact:

Re: Bug in 0.8.8a maybe?

Post by Tolaris »

I have a similar problem, squeak. The "select all" checkbox next to "Data Query [SNMP - Interface Statistics]" causes all interfaces to be selected, but also causes all hard drives to be selected on another query above ("Data Query [SNMP - Get Disk IO]". This is not a standard template, but can be found here:

http://docs.cacti.net/usertemplate:data:host_mib:diskio

The reverse is not true - selecting the check next to Disk IO does not select interfaces.

Devs are welcome to send me a PM to arrange access to an affected server. I have this problem on two instances, both running 0.8.8a, one on Ubuntu 12.04, one on Ubuntu 10.04.
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Bug in 0.8.8a maybe?

Post by gandalf »

I'll try to verify using the diskio stuff. The problem might be related to "certain" queries only. But I will test on RHEL ...
R.
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Bug in 0.8.8a maybe?

Post by gandalf »

An assumption (I was not able to verify this on our system):

Please note the data query id of those data queries, that get highlighted.
E.g., the interface traffic data query usually has id=1 (find this, when hovering e.g. the green circle on "Create Graphs for this Host").
I need that id AND all id's of all data queries that get highlighted, too.

R.
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Bug in 0.8.8a maybe?

Post by gandalf »

Please apply this patch

Code: Select all

--- graphs_new.php	2012-04-03 20:58:35.000000000 +0200
+++ graphs_new.php	2013-04-27 18:41:42.000000000 +0200
@@ -859,7 +859,7 @@
 					}else{
 						print "	<tr bgcolor='#" . $colors["header_panel"] . "'>
 								$html_dq_header
-								<td width='1%' align='center' bgcolor='#819bc0' style='" . get_checkbox_style() . "'><input type='checkbox' style='margin: 0px;' name='all_" . $snmp_query["id"] . "' title='Select All' onClick='SelectAll(\"sg_" . $snmp_query["id"] . "\",this.checked);dq_update_selection_indicators();'></td>\n
+								<td width='1%' align='center' bgcolor='#819bc0' style='" . get_checkbox_style() . "'><input type='checkbox' style='margin: 0px;' name='all_" . $snmp_query["id"] . "' title='Select All' onClick='SelectAll(\"sg_" . $snmp_query["id"] . "_\",this.checked);dq_update_selection_indicators();'></td>\n
 							</tr>\n";
 					}
wonder, whether you'll find the tiny underscore, which makes the fix 8)
R.
Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests