Weathermap 0.97a Released

Howie · Post by **Howie** » Tue Mar 09, 2010 9:02 am

Thanks to everyone who reported exciting new bugs in 0.97 - here is the result

	FIXED - Incorrect action URL in 'map selector' combo box for Cacti users.
	FIXED - cacti_graph_id set to 0 instead of ID, by rrd/poller_output and dsstats plugins (thanks sh0x)
	FIXED - 'classic' legend drew 'hidden' colour values for things like key background colour. (thanks jmayniac)
	FIXED - PHP 5.3 deprecated code in HTML_Imagemap.class.php
	FIXED - 'Show Only First' option ignored in Cacti (thanks inko_nick)
	FIXED - Editor deals with overlapping nodes on different ZORDERS properly.
	FIXED - "property of non-object in editor.php line 466" while editing map properties (thanks to iNeo)
	FIXED - no-data option on command-line didn't work 
	FIXED - Clone Node was broken in 0.97 
	FIXED - Maps with per-user permissions show up multiple times in map selector
	FIXED - Removed incorrect warning about imagefilter and USEICONSCALE.
	FIXED - string escaping bug with editor and direct config changes (thanks uhtred)
        FIXED - --imageuri was ignored on command-line (thanks Marcus StÃ¶gbauer)
	FIXED - links with targets containing spaces are broken by the editor (thanks Andreas Braun)
	FIXED - deprecated jQuery function call in cacti-pick.php (thanks again Andreas Braun)
	CHANGE - Group sorting is a bit more logical and the presentation nicer.
        CHANGE - cacti-integrate.php uses getopt to take more command-line params
	CHANGE - Updated jQuery to latest version
        CHANGE - Number formatting will pick 1G over 1000M (and similar) (thanks cerbum)
        CHANGE - The editor is disabled by default - see top of editor.php (and install guide)
	ADDED - LINK WIDTH accepts decimals
	ADDED - cacti-integrate.php can generate DSStats TARGETs too
	ADDED - Simple VIA editing in editor (thanks to Zdolny)
        ADDED - SCALE can accept G,M,K,T,m,u,n suffixes (for absolute scales)

DLNoah · Post by **DLNoah** » Fri Mar 12, 2010 1:05 pm

Has something changed in the way 0.97a handles USEICONSCALE for nodes? I upgraded from 0.97 to 0.97a this morning and it stopped applying the icon scale colors to my nodes.

I did a batch-copy of my image files, configuration files, custom font files, etc. from the old weathermap directory to the new one when I upgraded. Rolling back to 0.97 (renaming the new directory to something else and renaming the old directory back to weathermap) restores the expected behavior.

Looking through debug logging on both 0.97 and 0.97a, it appears the nodes are still correctly taking my template, and all of the log file entries are functionally equivalent between for one of the nodes I looked at that should be icon-scaling. The only thing that has changed is the actual numbers for some of the variables being retrieved by the cactihost target (because they're from different poller cycles).

Edit: Er, sorry, there is one line missing from the 0.97a logs that appears in the 0.97 logs -- I got my windows crossed when I was copy/pasting out of the big log file into smaller logs. 0.97 has the following lines toward the end of the drawing of a given node:

Code: Select all

03/12/2010 12:54:46 PM - WEATHERMAP: Poller[0] DEBUG: [DrawMap@Weathermap.class.php:3434] [Map 4] metalinkstatus.conf: Pre-rendering mavisap0-status to get bounding boxes.
03/12/2010 12:54:46 PM - WEATHERMAP: Poller[0] DEBUG: [pre_render@WeatherMapNode.class.php:177] [Map 4] metalinkstatus.conf: Colorising the icon
03/12/2010 12:54:46 PM - WEATHERMAP: Poller[0] DEBUG: [NewColourFromPercent@Weathermap.class.php:1244] [Map 4] metalinkstatus.conf: NCFPC mavisap0-status cactiupdown 3 'Up' 2.5_3.5 0 255 0
03/12/2010 12:54:46 PM - WEATHERMAP: Poller[0] DEBUG: [pre_render@WeatherMapNode.class.php:460] [Map 4] metalinkstatus.conf: If this is the last thing in your logs, you probably have a buggy GD library. Get > 2.0.33 or use PHP builtin.
03/12/2010 12:54:46 PM - WEATHERMAP: Poller[0] DEBUG: [pre_render@WeatherMapNode.class.php:470] [Map 4] metalinkstatus.conf: SCALING ICON here

0.97a is missing that final line for each node that should be using a scale. I'm running gd 2.0.33 release 9.4.el5_1.1; yum has the 9.4.el5_4.2 release available if you think that would be worth trying.

Howie · Post by **Howie** » Fri Mar 12, 2010 2:03 pm

Well, that's scaling as in resizing, not recolouring... hmm.

The 'crash with transparency' GD bug is in normal 2.0.33... it's hard to say with things like RHEL because they backport bugfixes.

Anyway, the basic stuff does work because I just added it to the test-suite (I'm working on a set of small repeatable tests for things that should be the same from version to version).

I've attached the results.

Incidentally, something you said the other day about the recolouring thing not being able to tell a black outline and leave it alone - as long as it is PURE 0,0,0 black, it should do exactly that. Same with white.

Edit: Run 'php check-gdbuig.php' to see if you have the GD bug. I don't see why 0.97->0.97a would make it appear though.

DLNoah · Post by **DLNoah** » Fri Mar 12, 2010 10:33 pm

Hm. I'll have to poke around some more when I get back to my normal system. On the road right now, will check after the weekend.

DLNoah · Post by **DLNoah** » Thu Mar 18, 2010 2:25 pm

Results of check-gdbug.php (from command line) in the WM 0.97 directory:

Code: Select all

# php check-gdbug.php
Some version of the GD graphics library have a bug in their handling of
Alpha channels. Unfortunately, Weathermap uses these to draw Nodes.

This program will test if your PHP installation is using a buggy GD
library.

If you are, you should either use PHP's built-in (aka 'bundled') GD
library, or update to GD Version 2.0.34 or newer. Weathermap REQUIRES
working Alpha support.

Let's see if you have the GD transparency bug...

If you see no more output, or a segfault, then you do, and you'll need to
upgrade.

If you get other errors, like 'undefined function', then run check.php to
make sure that your PHP installation is otherwise OK.

Here we go...

PHP Notice:  ob_flush(): failed to flush buffer. No buffer to flush. in /var/www/html/cacti/plugins/weathermap/check-gdbug.php on line 30
...nope. We got past the risky part, so that's good.
Your GD library looks healthy.

With 0.97a:

Code: Select all

# php check-gdbug.php
Some version of the GD graphics library have a bug in their handling of
Alpha channels. Unfortunately, Weathermap uses these to draw Nodes.

This program will test if your PHP installation is using a buggy GD
library.

If you are, you should either use PHP's built-in (aka 'bundled') GD
library, or update to GD Version 2.0.34 or newer. Weathermap REQUIRES
working Alpha support.

Let's see if you have the GD transparency bug...

If you see no more output, or a segfault, then you do, and you'll need to
upgrade.

If you get other errors, like 'undefined function', then run check.php to
make sure that your PHP installation is otherwise OK.

Here we go...

PHP Notice:  ob_flush(): failed to flush buffer. No buffer to flush. in /var/www/html/cacti/plugins/weathermap-0.97/check-gdbug.php on line 30
...nope. We got past the risky part, so that's good.
Your GD library looks healthy.

Problem described in my original post still persists on WM-0.97a.

Howie · Post by **Howie** » Thu Mar 18, 2010 2:57 pm

DLNoah wrote:
Problem described in my original post still persists on WM-0.97a.

which is that USEICONSCALE doesn't colour icons, to clarify?

with or without "SET "use_imagefilter 1"? and did you try it the other way?

DLNoah · Post by **DLNoah** » Thu Mar 18, 2010 5:08 pm

Yes, USEICONSCALE is not coloring the icons, either with or without SET use_imagefilter 1 in the map's configuration.

ETA: I thought there was a possibility that the coloring problem was being caused by my "black" base icon being too black, so I tried switching one of the icons to red. There is still no coloring occurring on either the black or red icons.

Howie · Post by **Howie** » Fri Mar 19, 2010 6:08 am

DLNoah wrote:Yes, USEICONSCALE is not coloring the icons, either with or without SET use_imagefilter 1 in the map's configuration.

ETA: I thought there was a possibility that the coloring problem was being caused by my "black" base icon being too black, so I tried switching one of the icons to red. There is still no coloring occurring on either the black or red icons.

OK - and on what OS? I can't think what would cause this, especially for both methods, so I'm just going to try and recreate your environment.

DLNoah · Post by **DLNoah** » Fri Mar 19, 2010 7:17 am

Linux cactiserver64.directlinkcomputers.local 2.6.18-128.1.16.el5 #1 SMP Tue Jun 30 06:07:26 EDT 2009 x86_64 x86_64 x86_64 GNU/Linux (CentOS 5.4). Cacti 0.8.7e, PIA 2.5. Other plugins installed include DSStats 1.1, Monitor 0.8.2, RRDClean 0.38, Settings 0.5, Thold 0.4.1, Titlechanger 0.1, Tools 0.3, and Update 0.4

Hardware is Dell PowerEdge 1850 with 16GB RAM. The CPU is the Dell original, the hard drives are 2x68GB SCSI.

Howie · Post by **Howie** » Fri Mar 19, 2010 7:19 am

DLNoah wrote:Linux cactiserver64.directlinkcomputers.local 2.6.18-128.1.16.el5 #1 SMP Tue Jun 30 06:07:26 EDT 2009 x86_64 x86_64 x86_64 GNU/Linux (CentOS 5.4). Cacti 0.8.7e, PIA 2.5. Other plugins installed include DSStats 1.1, Monitor 0.8.2, RRDClean 0.38, Settings 0.5, Thold 0.4.1, Titlechanger 0.1, Tools 0.3, and Update 0.4

Hardware is Dell PowerEdge 1850 with 16GB RAM. The CPU is the Dell original, the hard drives are 2x68GB SCSI.

And with the current CentOS php/gd/php-gd?

DLNoah · Post by **DLNoah** » Fri Mar 19, 2010 7:55 am

Sorry, not meaning to make you beat the information out of me with a hammer...

php: 5.1.6 23.2.el5_3
php-gd: 5.1.6 23.2.el5_3
gd: 2.0.33 9.4.el5_1.1

Current versions that yum update is showing is as follows:
php: 5.1.6 24.el5_4.5
php-gd: 5.1.6 24.el5_4.5
gd: 2.0.33 9.4.el5_4.2

Running a yum update right now, will re-upgrade to WM 0.97a and post back.

DLNoah · Post by **DLNoah** » Fri Mar 19, 2010 8:33 am

Updating to the newest php/php-gd/gd available on yum did not change the behavior. Updating to the latest kernel & restarting did not change the behavior - I still get my icons with whatever color they are in their native state.

Howie · Post by **Howie** » Fri Mar 19, 2010 9:17 am

OK thanks - I'll build a CentOs 5.4 VM over the weekend, and see if I can reproduce this. My own Cacti server is CentOS 64-bit, but actually in need of an update - currently running 5.2.

Howie · Post by **Howie** » Mon Mar 22, 2010 4:19 am

Linux cactiback 2.6.18-164.9.1.el5 #1 SMP Tue Dec 15 21:04:57 EST 2009 i686 i686 i386 GNU/Linux

CentOS release 5.4 (Final)

Both useiconscale methods are working for me.

So... could you get a small config that does the same thing with the same icon? And then I'll try that.

uhtred · Post by **uhtred** » Thu Apr 22, 2010 10:02 am

hi,

i did upgrade to the new version. thx for your work howie.
I have a 'problem' with the editor and existing maps:

1. open a map
2. select a node (with a link to another)
3. select edit
4. submit
error message: Notice: Undefined variable: link_config in /var/www/cacti/plugins/weathermap/editor.php on line 273

Warning: Cannot modify header information - headers already sent by (output started at /var/www/cacti/plugins/weathermap/editor.php:273) in /var/www/cacti/plugins/weathermap/editor.php on line 890

dont know, where it comes from. any idea?

thx

Weathermap 0.97a Released

Weathermap 0.97a Released

Who is online