Warning: reset(): ....../cacti/lib/functions.php on line 146

[nifi]

i used cacti0.8.7b and PA2
with no PA2,my cacti works ok,but after i patch the PA2,and i have changed the global.php,plugins.php and so on,there is a warning message to me:
Warning: reset(): Passed variable is not an array or object in /var/www/cacti/lib/functions.php on line 146

Warning: Variable passed to each() is not an array or object in /var/www/cacti/lib/functions.php on line 147

i searched in forums,but have no idea to solve it.i don't know what should i do!
about pa.sql,should i import it into cacti.sql,or replace the cacti.sql with pa.sql?

[TheWitness]

I saw a note related to this the other day. I asked the user to fill out a bug report at http://bugs.cacti.net. Check there, or google the reset() thingy. It had something to do with PHP versions and the user posted a fix.

TheWitness

[incudie]

Nifi have you had any luck finding a resolution?

I have run into the same problem after a fresh install and am currently looking for a solution. Have not had any luck finding what TheWitness was referencing.

If you have any more information that would be appreciated,

Thanks

[nifi]

I have no idea yet!

[incudie]

Hmm do you happen to be running apache2 and php5 by any chance?

[TheWitness]

This would appear to be plugin related. I am experiencing it now. Superlinks was causing the issue. Don't know why as of yet.

TheWitness

[incudie]

So far I have had this problem with only the latest plugin architecture installed (without any plugins). But for comparison to anyone else here are my plugins,

Code: Select all

$plugins = array();
$plugins[] = 'aggregate';
$plugins[] = 'reportit';
$plugins[] = 'monitor';
$plugins[] = 'settings';
$plugins[] = 'thold';
$plugins[] = 'tools';
$plugins[] = 'reports';
$plugins[] = 'killspike';
$plugins[] = 'weathermap';

[TheWitness]

The fix is as follows:

Edit lib/functions.php and change the code at or about line 125 to the code below:

Code: Select all

	if (is_array($settings)) {
	reset($settings);
	while (list($tab_name, $tab_array) = each($settings)) {
		if ((isset($tab_array[$config_name])) && (isset($tab_array[$config_name]["default"]))) {
			return $tab_array[$config_name]["default"];
		}else{
			while (list($field_name, $field_array) = each($tab_array)) {
				if ((isset($field_array["items"])) && (isset($field_array["items"][$config_name])) && (isset($field_array["items"][$config_name]["default"]))) {
					return $field_array["items"][$config_name]["default"];
				}
			}
		}
	}
	}

This should solve the problem. Don't forget to backup you file first.

Regards,

TheWitenss

[incudie]

TheWitness 's change has successfully resolved my issue.

(Lot better than having errors turned off in php...)

Thank you very much Sir!

--Incudie

[outbreakmonkey]

I upgraded from 8.6i to 8.7b and as well as the adodb.inc.php issue, I have encountered this reset() problem.
I applied the fix as suggested but it completely breaks cacti.
The error message I get instead is

Parse error: syntax error, unexpected $end in /usr/share/cacti/site/lib/functions.php on line 1942

[Howie]

I upgraded from 8.6i to 8.7b and as well as the adodb.inc.php issue, I have encountered this reset() problem.
I applied the fix as suggested but it completely breaks cacti.
The error message I get instead is

Parse error: syntax error, unexpected $end in /usr/share/cacti/site/lib/functions.php on line 1942

Get the file back out of the original zip/tar and try again... that's usually a sign that you have missed a } somewhere.

[phalek]

Hi, I had the same issue and I actually found this related to the $user_auth_real_filenames and the $nav array.

you'll need to have the plugin file (e.g. nimd.php) configured in both arrays. If it's not present in the $nav array, the error you described occurs.

Example:

Code: Select all

function nmid_config_arrays () {
...
$user_auth_realm_filenames['nmid.php'] = 1191;
...
}

function nmid_draw_navigation_text ($nav) {
...
$nav["nmid.php:"] = array("title" => "NMID", "mapping" => "index.php:", "url" => "nmid.php", "level" => "1");
...
}

[TheWitness]

I have asked Roman and Ian to publish this patch. Still waiting...

TheWitness

[Howie]

Just so I understand, is this a patch to 'defend' against something bad that superlinks is doing, or is it actually an error in the way Cacti does it? I have never full understood how this particular part of Cacti works internally...

[TheWitness]

Well, it depends on how you look at it What you are doing in superlinks is making a database connection out of order so that you can modify the various arrays. By doing so, you run into the uninitialized array, which is a bad practice on our part. Ian always warned, don't ever assume an array is initialized by doing something stupid like "reset()" prior to if (is_array(blah)).

So, by doing things out of order, you introduced a new failure mode. However, because I LOVE Superlinks SOOO much, I decided to fix our poor coding.

I think there is another fix, to connect to the database much sooner in the global.php initialization process, but that would require me to think. Since my brain is quite close to exploding, I took the shortcut.

Regards,

Larry