thold 0.3.9 not support batch apply thresholds?

[looc]

in older thold,it can be apply threholds in the devices page.
but i new install 0.3.9, in the devices,select one or more hosts,use action to apply thresholds,the next page list not any threhold apply?why?

[looc]

why onbody can be tell me that?you never occur this ?

[Howie]

why onbody can be tell me that?you never occur this ?

I use 0.8.7a and thold 0.3.9 and I don't get this problem. I have added thresholds this way last week.

Do the devices selected *have* the data sources that you have templates for? (if you see what I mean

(I'd like to be able to have different threshold templates for different customers, but that's a different story)

[looc]

in the concretely device, i can be used Auto-create thresholds to apply tholds.but in the divices list i can't apply tholds yet

[TheGrudge]

I'm also not able to create thresholds. I never used the cacti plugins before, so I'm very new to all this stuff.

All installed versions of my plugins can be found in the attachment.

I created a threshold template for UNIX-Load Average/5min, but I can not auto create any threshold, nothing happens. I'm also not able to create a threshold via datasources->add like it is mentioned in the treshold overview.
Maybe I'm doing something wrong, but I can't figure it out and unfortunately no documentation can be found here.
Is this plugin broken? Dead host notification is working fine, but I can't create thresholds for specific tasks... and I also get the "poller has not been run yet" phrase...

[TheGrudge]

Ok now it seems to work (I don't know why), but only if I click on a specific device in the devices list and choose "create new graph / auto-create threshold". If I just select one or more devices in the list overview and choose from the dropdown-menu "apply thresholds", no thresholds are created. Am I doing something wrong or is it just not working with cacti 0.8.7b...?

[saya]

ya mine is cacti 0.8.7a and thold0.3.9
when i just installed this plugin, it could choose to apply threshold to all device...but after a few days, this way don't work, just like ur case...can only create threshold seperately...I dont know what I did on it..

[ahouston]

OK - I think I've got this one figured out... looks like the Monitor plugin is incorrectly returning $action instead of $save in its

I've been putting some debugging output in the include/plugins.php and plugins/thold/setup.php files because it appeared that the whole thing was sticking in the thold_device_action_prepare() function.

Here is the debug from the first run:

Code: Select all

Debug do_function_hook() :
Array ( [drp_action] => thold [host_list] => 
ar1-lei

ar1-lgr
[host_array] => Array ( [0] => 27 [1] => 30 ) ) 
Hooks:
Array ( [monitor] => monitor_device_action_prepare [thold] => thold_device_action_prepare ) 

Debug thold_device_action_prepare():
thold  

OK , so it appears that the $save array is actually set to a scalar 'thold' by the time it gets to the thold_device_action_prepare() function, even though it left the do_function_hook() function with the correct values !?

The do_function_hook is calling the prepare function for another plugin - Monitor - prior to it calling Thold.

A quick look at the monitor plugin's monitor_device_action_prepare() shows the problem, its returning a local value $action instead of the $save array which is required by the following prepare function in the list, namely thold's one..

Code: Select all

function monitor_device_action_prepare($save) {
        global $colors, $host_list;
        $action = $save['drp_action'];
        if ($action != 'monitor_enable' || $action != 'monitor_disable')
                return $action;  <== Change this to: return $save 

Update: Looks like you need to correct the behaviour in the monitor_device_action_execute() function too ?!!

Code: Select all

function monitor_device_action_execute ($action) {
        global $config;

        if ($action != 'monitor_enable' && $action != 'monitor_disable')
                return; <=== Change this to:  return $action;

So to fix, I guess either correct the return statement(s) in plugins/monitor/setup.php as above or just comment out the monitor plugin out in include/global.php

Hope that helps

[TheGrudge]

Disabling the monitor plugin did the trick. I just created all my thresholds and enabled monitor again...

[TheGrudge]

The Discover-Plugin is also working again, with monitor enabled I couldn't add new devices to Cacti.