ReportIt v0.5.1 and Cacti 0.8.7

Post by **browniebraun** » Wed Oct 24, 2007 12:15 pm

FYI!
Version 0.5.1 of ReportIt works with Cacti 0.8.7 without any changes.

It's a pity that the developers changed the default width of all tables.

IMO the old setting (98% relative) looks better.

Best regards
-Andreas-

Post by **TheWitness** » Wed Oct 24, 2007 8:47 pm

The top header was modified to include a bounding box on the left and right that even though the table is at 100% there is a roughly 1% boarder on all sides. Are you not experiencing this? Post a screen shot. I tested it on 5 different browsers and it worked on all.

TheWitness

cigamit · Post by **cigamit** » Thu Oct 25, 2007 12:20 am

Actually, the front end works fine, but I committed a patch for the back end of reportit to fix an issue with 0.8.7.

Index: runtime.php
===================================================================
--- runtime.php (revision 124)
+++ runtime.php (revision 125)
@@ -39,7 +39,11 @@
$path = dirname(__FILE__);
chdir($path);
chdir('../../');
- include_once('./include/config.php');
+ if (file_exists('./include/global.php')) {
+ include_once('./include/global.php');
+ } else {
+ include_once('./include/config.php');
+ }
include_once($config["base_path"] . '/plugins/reportit/setup.php');
include_once($config["base_path"] . '/plugins/reportit/lib_int/funct_shared.php');
include_once($config["base_path"] . '/plugins/reportit/lib_int/const_runtime.php');

Post by **browniebraun** » Thu Oct 25, 2007 1:24 am

Hi Jimmy!
Okay it's early in the morning and maybe I need a coffee first

, but it seems to me that you've patched v0.4.2 and not the current release.

The v0.5.1 contains these fixes. I wrote them during the development of 0.8.6k.(Before it has been called 0.8.7

)

Code: Select all

        $path = dirname(__FILE__);
        chdir($path);
        chdir('../../');

        /* Try to support 0.8.7 and lower versions as well*/
        if(is_file('./include/global.php')) include_once('./include/global.php');
        else include_once('./include/config.php');

        include_once($config["base_path"] . '/plugins/reportit/setup.php');

cigamit · Post by **cigamit** » Thu Oct 25, 2007 8:42 am

browniebraun wrote:Hi Jimmy!
Okay it's early in the morning and maybe I need a coffee first , but it seems to me that you've patched v0.4.2 and not the current release.

The v0.5.1 contains these fixes. I wrote them during the development of 0.8.6k.(Before it has been called 0.8.7 )

Hum... I patched what was in the cacti plugins SVN, didn't know you were not the one updating the svn copy, or why its even there if you are not.

Post by **browniebraun** » Thu Oct 25, 2007 10:02 am

Hi Jimmy!
I got no write access, so that I'm not able to update it. After a discussion with Reinhard 2 months ago we decided to move ReportIt to Sourceforge, because it is not really practicable for me without the right permissions. If I remember correctly Reinhard wanted to update it with every release, but it seems that he forgot it. I'm really sorry.

Best regards
-Andreas-

Post by **gandalf** » Fri Oct 26, 2007 3:10 pm

Oh, that's all my fault. Apologies. Will have to keep two different SVNs up to date. My bad
Reinhard

Post by **TheWitness** » Fri Oct 26, 2007 4:19 pm

You should have that access IMHO. Did you want it?

Larry

Post by **gandalf** » Sat Oct 27, 2007 5:36 am

I indeed have access both to the sourceforge SVN or Reportit and the Cacti SVN. See, we are running two SVNs in parallel, because browniebraun does not have access to the cacti one.
So I have to fetch the sourceforge one and to commit it to the cacti svn. That's what I've missed in the past few weeks. I'm currently working on it
Reinhard

Post by **gandalf** » Sat Oct 27, 2007 7:25 am

Struggeling with Eclipse and SVN for a while

...
Should not be fixed even in cacti plugin SVN.
But we really need some other method. svnsync will not be the solution, I suppose. And as browniebraun is the primary developer of this plugin, it's not nice for me to replicate all updates manually to cacti svn, even if only required on a new version release.
Ideas? Warehouse? Repository???
It surely has no pressure on it; lets fix 087 stuff first
Reinhard

Howie · Post by **Howie** » Sat Oct 27, 2007 8:45 am

Just curious... why does it need to be in the cacti svn at all, if that's not where the primary developer is working? It's not code that's delivered as part of Cacti itself, after all.

Post by **TheWitness** » Mon Oct 29, 2007 7:30 pm

It make no difference to me.... Just thought I would offer it up.

Larry

Post by **browniebraun** » Mon Oct 29, 2007 11:51 pm

Larry,
I would appreciate it to have these rights, but IMO this has to be a decision of all the main developers too.
BTW I agree with Reinhard that 0.8.7 should have the highest priority at the moment.

Best regards
-Andreas-

Post by **TheWitness** » Tue Oct 30, 2007 6:39 am

Agreed. Three patches and counting

TheWitness

sizulku · Post by **sizulku** » Tue Oct 30, 2007 7:42 am

TheWitness,

where is the place you publish the patches? I can't find it on cacti official patches website (http://www.cacti.net/download_patches.php)

Zul

ReportIt v0.5.1 and Cacti 0.8.7

ReportIt v0.5.1 and Cacti 0.8.7

Who is online