PHP Warning: Division by zero

[Conz]

I'm trying to get weathermap going on a new fedora 7 machine and its telling me: PHP Warning: Division by zero in /var/www/html/cacti/plugins/weathermap/setup.php on line 314

I have it running on FC5 with no problems, the map DOES get correctly rendered on F7 so it might be cosmetic.

Any ideas ?

[Howie]

I'm trying to get weathermap going on a new fedora 7 machine and its telling me: PHP Warning: Division by zero in /var/www/html/cacti/plugins/weathermap/setup.php on line 314

I have it running on FC5 with no problems, the map DOES get correctly rendered on F7 so it might be cosmetic.

Any ideas ?

Do you get this more than once? It looks like a default is not being set correctly. You should be able to fix it by going into the Settings..Misc in Cacti, and setting the Map Rendering Interval to Every Polling Cycle, which should re-write the setting.

[Conz]

Ok i tried that and that didn't help, i did find out after some experimenting that it has to do with the weathermap_render_period and weathermap_render_counter variables, when i change the update cycle to manual or anything but every update poller cycle causes the error.

fixed it by changing setup.php (around line 314):

Code: Select all

                if( ($rendercounter % $renderperiod) == 0)
                         {
                        weathermap_run_maps(dirname(__FILE__) );
                }

To:

Code: Select all

                if ($renderperiod == 0) {
                        weathermap_run_maps(dirname(__FILE__) );
                } else if( ($rendercounter % $renderperiod) == 0) {
                        weathermap_run_maps(dirname(__FILE__) );
                }

it seems that renderperiod 0 is every update and 1 is manual, allthough somehow i think it should be the other way around.

[Howie]

Hmm. There was some discussion of this once before. My understanding was that anything mod 0 is 0 but it seems that in at least some php versions, that's not the case.

I'll make the change as you suggest, I think.

[Conz]

It might be because i botched something else up of which i cant really remember what it would be though.
just fyi, F7 has php 5.2.2 on it, its the normal rpm version which came with it, and any current updates.