Possible bug in lib/ping.php? Cacti 0.8.6j with patches.

[andy_griffiths]

While trying to work out why my non SNMP device wasnt responding to UDP pings (switched to ICMP now) I think I found the following problem in ping.php while I had debug switched on.

The log always reported :

07/09/2007 12:05:21 PM - CMDPHP: Poller[0] Host[49] PING: default

whereas I could see from the code it should be reporting 'UDP ping Timed out' or 'Refused'.

The condition block at line 383 was setting values in $this->response, a previously unused variable. I changed it to $this->ping_response (like all the other reported conditions) and now it reported correctly in the log.

So the changed code reads :

383 if ($retry_count >= $this->retries) {
384 $this->status = "down";
385 if ($error == "timeout") {
386 $this->ping_response = "UDP ping Timed out";
387 }else{
388 $this->ping_response = "UDP ping Refused";
389 }
390 $this->close_socket();
391
392 return false;
393 }

I don't know if I'm the first to see this, but could whoever maintains the fine code please check?

[TheWitness]

Could you please open a bug at bugs.cacti.net and then report back here that you have done so. Also, please add the content here into the bug report.

Thanks,

TheWitness

[andy_griffiths]

Will do.

[andy_griffiths]

Raised #970

--
Andy