Ad blocker detected: Our website is made possible by displaying online advertisements to our visitors. Please consider supporting us by disabling your ad blocker on our website.
this works for normal cacti, but not for the thold plugin
in the plugin I get a division by zero error.
after looking at the thold source, is looks like the plugin never grabs the values from the rrd file
The thold plugin currently only does the basic CDEF functions, so anything with CURRENT_GRAPH_MAXIMUM_VALUE doesn't work (basically only CURRENT_DATA_SOURCE and simple math equations). I have to calculate the CDEF manually for now, which I can tell you is a big pain.
Well, after a few minor modifications, this patch is now in the SVN version.
The modifications aren't because of problems with your code, but I had to adapt it to the new way that thold checks (it now grabs the current data from the poller output instead of directly from the rrd file).
cigamit wrote:Well, after a few minor modifications, this patch is now in the SVN version.
The modifications aren't because of problems with your code, but I had to adapt it to the new way that thold checks (it now grabs the current data from the poller output instead of directly from the rrd file).
The new version will be released in about a week, so don't fret. There are still a few wrinkles to iron out, but so far everything is working fairly well.
cigamit wrote:The new version will be released in about a week, so don't fret. There are still a few wrinkles to iron out, but so far everything is working fairly well.
I need to do the same sort of thing for interface traffic. the 0.3.0 version I just downloaded has files with a timestamp of july 25th, which leads me to believe the answer is "yes". I already have a bandwidth percentage CDEF I'm using for the graphs, so once I apply the patch can I just put "90" in for the high threshold and it will alert me when the traffic goes above 90%?
edited to add: well, I decided to go ahead and try it just for fun, and I got a divide by zero after applying the patch.
Warning: Division by zero in /www/htdocs/cacti-0.8.6h/plugins/thold/thold-functions.php on line 108
here's my percentage CDEF:
Attachments
thold-problem.jpg (59.48 KiB) Viewed 13428 times
Last edited by daemon on Thu Nov 02, 2006 3:56 pm, edited 1 time in total.
I took a wild guess and decided to change |query_ifspeed| to CURRENT_DS_MAXIMUM_VALUE, and now it isn't getting divide by zero errors but the current value is always 800 for almost all the interfaces. since the formula is (current value/ifspeed)*8*100, it's almost as if (current value/ifspeed) is getting rounded up to 1 or something. if I graph the values using the same CDEF they show up fine, so I'm at a bit of a loss here.
I'm also curious, if I use CURRENT_DS_MAXIMUM_VALUE, and the speed of the interface changes, will this value update or do I have to refresh the indexes using the green circle thingie?
I've done some more digging and after examining thold-functions.php I think I found where the problem lies. here's an excerpt of some print statements I threw into the file:
CURRENT_DATA_SOURCE
CDEF value: 276.656
CURRENT_DS_MAXIMUM_VALUE
CDEF value: 276.656
oldvalue: 276.656
value: 276.656
id: 17
rra: 2354
ds: traffic_in
cdef[value]: 3
entering thold_rpn...x is 276.656, y is 276.656, z is 4
returning 276.656 / 276.656
entering thold_rpn...x is 1, y is 100, z is 3
returning 1 * 100
entering thold_rpn...x is 100, y is 8, z is 3
returning 100 * 8
for some reason, in the case statement for CURRENT_DS_MAXIMUM_VALUE it's coming back with CURRENT_DATA_SOURCE, which is where the 800 is coming from (CURRENT_DATA_SOURCE / CURRENT_DATA_SOURCE * 800). any idea why $cdef['value'] = get_current_value($rra, 'rrd_maximum', 0); would be returning the same number as $cdef['value'] = get_current_value($rra, $ds, 0);?
I think that you made the same mistake that I did daemon, you used the CURRENT_DS_MAXIMUM_VALUE when you should have used the CURRENT_GRAPH_MAXIMUM_VALUE.
At least that is what I belevide that I did wrong since I have one machine that also triggers at 100% I recently changed the CDEF and will see in a few minutes if that was the cause
Seams like I cheered prematurelly, this is really strange. The CDEF works for all other devices except just this one which has 8.65 G used of 31.43 G total and the CDEF according to Thold tells me that it is using 100%
yea, CURRENT_GRAPH_MAXIMUM_VALUE didn't work for me either. the thing that really confuses me is that CURRENT_DS_MAXIMUM_VALUE works just fine when it comes to getting the values on a graph.
