graphs_view.php broken in dual pane tree view

[rony]

I'm working on it..

Will be reviewing this issue this weekend.

[jmjones]

I have been battling this issue for quite some time. I have created a kindof make shift patch, and now I have created a patch that allows "no loss" in functionality. Here it is. In top_graph_header.php you will see the following chunk of code

/* setup tree selection defaults if the user has not been here before */
if ((read_graph_config_option("default_tree_view_mode") == "2") && ($_REQUEST["action"] == "tree") && (!isset($_SESSION["sess_has_viewed_graphs"]))) {
$_SESSION["sess_has_viewed_graphs"] = true;

$first_branch = find_first_folder_url();

if (!empty($first_branch)) {
header("Location: $first_branch");
}
}


This is where the infinite redirection loop is on some server setups. Here is my patch. It uses a javascript redirect instead of a server side redirect. This slows the server down just long enough to not get "confused".

Comment out the above code and add this code right underneath it.

/* setup tree selection defaults if the user has not been here before */
if ((read_graph_config_option("default_tree_view_mode") == "2") && ($_REQUEST["action"] == "tree") && (!isset($_SESSION["sess_has_viewed_graphs"]))) {
$_SESSION["sess_has_viewed_graphs"] = true;

$first_branch = find_first_folder_url();
if (!empty($first_branch)) {
if(!empty($_REQUEST["ret"])){
$mystring = "&ret=yes";
$first_branch = $first_branch . $mystring;
header("Location: $first_branch");
}
//print "The first branch was not empty" .$first_branch;
print "<script language=\"javascript\">window.location.href=\"$first_branch\"</script>" ;
}
}

It should look like this when you are done.

/* setup tree selection defaults if the user has not been here before */
if ((read_graph_config_option("default_tree_view_mode") == "2") && ($_REQUEST["action"] == "tree") && (!isset($_SESSION["sess_has_viewed_graphs"]))) {
$_SESSION["sess_has_viewed_graphs"] = true;

$first_branch = find_first_folder_url();
if (!empty($first_branch)) {
if(!empty($_REQUEST["ret"])){
$mystring = "&ret=yes";
$first_branch = $first_branch . $mystring;
header("Location: $first_branch");
}
//print "The first branch was not empty" .$first_branch;
print "<script language=\"javascript\">window.location.href=\"$first_branch\"</script>" ;
}
}
/* setup tree selection defaults if the user has not been here before */
/*if ((read_graph_config_option("default_tree_view_mode") == "2") && ($_REQUEST["action"] == "tree") && (!isset($_SESSION["sess_has_viewed_graphs"]))) {
$_SESSION["sess_has_viewed_graphs"] = true;

$first_branch = find_first_folder_url();

if (!empty($first_branch)) {
header("Location: $first_branch");
}
}
*/

I have attached my copy of the file for download as well

[dvincent]

I'm working on it..

Will be reviewing this issue this weekend.

do you know if this problem has been addressed? I implemented the fix below and it seems to work, but with a small delay. where you able to determine the cause?

Dave