SQL Error

[phakesley]

in the plugins/thold directory edit setup.php (first making a backup)
Locate on line 203

$thold_items = db_fetch_assoc("select thold_data.cdef, thold_data.rra_id, thold_data.data_id, thold_data.lastread, thold_data.oldvalue, data_template_rrd.data_source_name as name, data_template_rrd.data_source_type_id from thold_data
LEFT JOIN data_template_rrd on (data_template_rrd.id = thold_data.data_id)
WHERE data_template_rrd.data_source_name != '' AND $rra_ids");

and change to


if ($rrd_ids != '') {
$thold_items = db_fetch_assoc("select thold_data.cdef, thold_data.rra_id, thold_data.data_id, thold_data.lastread, thold_data.oldvalue, data_template_rrd.data_source_name as name, data_template_rrd.data_source_type_id from thold_data
LEFT JOIN data_template_rrd on (data_template_rrd.id = thold_data.data_id)
WHERE data_template_rrd.data_source_name != '' AND $rra_ids");
} else {
$thold_items = db_fetch_assoc("select thold_data.cdef, thold_data.rra_id, thold_data.data_id, thold_data.lastread, thold_data.oldvalue, data_template_rrd.data_source_name as name, data_template_rrd.data_source_type_id from thold_data
LEFT JOIN data_template_rrd on (data_template_rrd.id = thold_data.data_id)
WHERE data_template_rrd.data_source_name != '' ");
}
This removes the SQL error from CACTI log file and does not seem to affect thresholds?

[imjames407]

Its nice one for programmers.

[cigamit]

I just have to assume your now using 4.0 (or even 4.1) as this code was moved in that version, and a better fix was added to it.