Sorting of graphs and columns

[sysmgr3]

How can add this patch?

Tnx

[gandalf]

Copy this stuff into a file of your liking

Code: Select all

--- cacti.orig/lib/html_tree.php        2006-10-08 20:06:01.000000000 -0700
+++ cacti/lib/html_tree.php     2006-11-13 17:18:24.000000000 -0800
@@ -457,6 +457,10 @@
        return $dhtml_tree;
 }

+function nat_sort_graphs($a, $b) {
+       return strnatcasecmp($a['title_cache'], $b['title_cache']);
+}
+
 function grow_right_pane_tree($tree_id, $leaf_id, $host_group_data) {
        global $current_user, $colors, $config;

@@ -586,6 +590,7 @@
                                        and graph_local.host_id=" . $leaf["host_id"] . "
                                        $sql_where
                                        order by graph_templates_graph.title_cache");
+                               usort($graphs, 'nat_sort_graphs');

                                if (read_graph_config_option("thumbnail_section_tree_2") == "on") {
                                        html_graph_thumbnail_area($graphs, "", "view_type=tree&graph_start=" . get_current_graph_start() . "&graph_end=" . get_current_graph_end(), "<tr bgcolor='#a9b7cb'><td colspa
n='3' class='textHeaderDark'><strong>Graph Template:</strong> " . $graph_template["name"] . "</td></tr>");

and save it to the main cacti directory. From command line, enter

Code: Select all

patch -p1 -N < your.patch

where your.patch is the file you've just created
Reinhard

[VinceV]

FYI: This patch has been incorporated into cacti 0.8.6j.

[TheWitness]

You are correct.

TheWitness

[m4tth3wv]

Updated to cacti 0.8.6j. Graph tree's are "natural sorting".

The graphs and datasources view incorrectly.

List of data sources:

[TheWitness]

Well, I didn't add it to the Data Source list. I guess I was simply adding to the Tree and Host Graph displays and not either the Data Sources or Graphs from the Console. Hmm. Can you log another feature request in Mantis. (http://bugs.cacti.net). Sorry about that...

[timi]

10x i'm using .6h with this hack http://forums.cacti.net/viewtopic.php?t ... light=sort

[m4tth3wv]

This maybe something I'm doing, since the graphs do not sort properly either. I tried the other hack as well.

I'll go ahead and submit the bug request for the datasources.

[Zxin]

There is no sorting method for a "Host" type (or at least I can't find it), or to do this I would have to add individual graphs.
I currently have:

Default Tree
- Infrastructure (Heading)
- Host: Switch 1 (Graph)

I have tried changing to natural at the Infrastructure level and click on propagate changes, but it did not affect the each host Host graph.

Am I missing something?

-Thomas

What happens if you change the sort order in 0.8.6i to Natural? This should have fixed this. No patch should be required.

TheWitness

[TheWitness]

m4tth3wv,

The picture you post is properly sorted.

TheWitness

[m4tth3wv]

The order goes like this:

gi0/1
gi0/10
gi0/11
......
gi0/2

An expected order would be:

gi0/1
gi0/2
gi0/3
.....
gi0/10
gi0/11

[TheWitness]

Hmm,

Change the display order from Graph Template to Data Query based for this host and see if it works in one version but not in the next. More QA on contributions I am thinking.

TheWitness

[Zxin]

Worked like a charm for me.
Thanks!

-Thomas

Hmm,

Change the display order from Graph Template to Data Query based for this host and see if it works in one version but not in the next. More QA on contributions I am thinking.

TheWitness

[TheWitness]

Zwim,

Can you please add a bug report indicating which host display type is not properly sorting. I don't have the time to research it, and need your feedback. The site is http://bugs.cacti.net

Thanks,

TheWitness

[m4tth3wv]

That works for me too.

If Zwim didn't create a bug report, let me know and I will.

Thanks, again.