Previous and Next

Anything that you think should be in Cacti.

Moderators: Developers, Moderators

Post Reply
Hiney
Cacti User
Posts: 56
Joined: Mon Oct 16, 2006 11:50 pm

Previous and Next

Post by Hiney »

Can previous and next disappear when they aren't appropriate. I find it quite confusing clicking on things that sometimes work and sometimes don't (like "previous" when you are on the first page of a display).

for example in "function html_nav_bar()" in html.php, the following changes could be made :

from

Code: Select all

	<strong><<  <?php if ($current_page > 1) { print "<a class='linkOverDark' href='" . str_replace("<PAGE>", ($current_page-1), $nav_url) . "'>"; } print "Previous"; if ($current_page > 1) { print "</a>"; } ?></strong>
to

Code: Select all

<?php if ($current_page > 1) { print "<strong><a class='linkOverDark' href='" . str_replace("<PAGE>", ($current_page-1), $nav_url) . "'> << Previous</a></strong>"; }  ?>
from

Code: Select all

<strong><?php if (($current_page * $rows_per_page) < $total_rows) { print "<a class='linkOverDark' href='" . str_replace("<PAGE>", ($current_page+1), $nav_url) . "'>"; } print "Next"; if (($current_page * $rows_per_page) < $total_rows) { print "</a>"; } ?> >></strong>
to

Code: Select all

	<?php if (($current_page * $rows_per_page) < $total_rows) { print "<strong><a class='linkOverDark' href='" . str_replace("<PAGE>", ($current_page+1), $nav_url) . "'> Next >> </a></strong>"; } ?>

Suprisingly, this doesn't do them all. Each other .php's that does listing has it's own (data_sources.php, data_templates.php, graph_templates.php, etc).


TIA
H
Attachments
just a piccie with previous missing at the start of a list.
just a piccie with previous missing at the start of a list.
1.jpg (53.47 KiB) Viewed 3708 times
User avatar
TheWitness
Developer
Posts: 17061
Joined: Tue May 14, 2002 5:08 pm
Location: MI, USA
Contact:

Post by TheWitness »

Please add as feature request in Mantis (bugs.cacti.net).

TheWitness
True understanding begins only when we realize how little we truly understand...

Life is an adventure, let yours begin with Cacti!

Author of dozens of Cacti plugins and customization's. Advocate of LAMP, MariaDB, IBM Spectrum LSF and the world of batch. Creator of IBM Spectrum RTM, author of quite a bit of unpublished work and most of Cacti's bugs.
_________________
Official Cacti Documentation
GitHub Repository with Supported Plugins
Percona Device Packages (no support)
Interesting Device Packages


For those wondering, I'm still here, but lost in the shadows. Yearning for less bugs. Who want's a Cacti 1.3/2.0? Streams anyone?
Hiney
Cacti User
Posts: 56
Joined: Mon Oct 16, 2006 11:50 pm

Post by Hiney »

TheWitness wrote:Please add as feature request in Mantis (bugs.cacti.net).

TheWitness
thanks, but what does that mean ?

H
User avatar
TheWitness
Developer
Posts: 17061
Joined: Tue May 14, 2002 5:08 pm
Location: MI, USA
Contact:

Post by TheWitness »

We do not "track" bugs from the forum. We only track bug's from the Mantis bug site. I believe this was inadvertantly left out. The "top" is a good feature request though. They are officially log'd in the Mantis bug system as well.

TheWitness
True understanding begins only when we realize how little we truly understand...

Life is an adventure, let yours begin with Cacti!

Author of dozens of Cacti plugins and customization's. Advocate of LAMP, MariaDB, IBM Spectrum LSF and the world of batch. Creator of IBM Spectrum RTM, author of quite a bit of unpublished work and most of Cacti's bugs.
_________________
Official Cacti Documentation
GitHub Repository with Supported Plugins
Percona Device Packages (no support)
Interesting Device Packages


For those wondering, I'm still here, but lost in the shadows. Yearning for less bugs. Who want's a Cacti 1.3/2.0? Streams anyone?
Hiney
Cacti User
Posts: 56
Joined: Mon Oct 16, 2006 11:50 pm

done

Post by Hiney »

TheWitness wrote:Please add as feature request in Mantis (bugs.cacti.net).

TheWitness
Issue 0852
Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests