Thold precentage limits patch

johnrembo · Post by **johnrembo** » Mon Apr 24, 2006 4:27 am

hello verybody,

thold_prec_eval.diff allows to set precentage tresholds
(for example instead of digit value in upper limit field in thold template you can now enter 90%). Percent values are counted considering graph scale.
patch must be applied to check-thold.php.

thold_autocreate.diff must be applied to host.php - it allows to create tresholds for all currently listed devices. In device section below "Add" new operation will apear - "Treshold listed devices".

both patches tested and working

Post by **rony** » Wed Apr 26, 2006 3:13 pm

Let Cigamit know about this.

cigamit · Post by **cigamit** » Mon May 01, 2006 10:04 pm

Only issue I have is that it has to modify /host.php parmamently for the thold plugin. The best way of doing this, is to instead modify host.php via the "Plugin Architecture" to add a hook to add columns to the table. This way it is seperate from Thold, and any plugin could do the same thing.

johnrembo · Post by **johnrembo** » Wed May 03, 2006 12:32 am

ok, i'll try to avoid this in future...

cigamit · Post by **cigamit** » Wed May 03, 2006 10:44 pm

I will let you know when I get the time to add the new hook the plugin architecture. At that time, I will also add this to the thold plugin.

I've been fairly busy lately, so don't expect it very quickly. I need to finish up the Event Manager code I have been workin on first.

wd · Post by wd » Fri May 12, 2006 9:36 pm

Didn't work...
Cacti treated 90% as 90....

darkstar · Post by **darkstar** » Sun May 14, 2006 10:44 pm

Hi,

which version of cacti/thold is the patch created against?

I've tried the patches, but it seems the percentage hi/low thold values "rounded" and stored without the '%' char before inserted in DB (thold-functions.php) during the threshold creation.

I am testing using cacti 0.8.6h and thold 0.2.9

Regards.

benzopila · Post by **benzopila** » Thu Aug 17, 2006 7:52 am

cigamit wrote:I will let you know when I get the time to add the new hook the plugin architecture. At that time, I will also add this to the thold plugin.

I've been fairly busy lately, so don't expect it very quickly. I need to finish up the Event Manager code I have been workin on first.

Have you working whith this?
Is this feature in 0.3 THold plugin?

Thanks

Tekk · Post by **Tekk** » Wed Aug 23, 2006 4:41 am

I also tried this patch and it didn't work for me.

My config :
Cacti on FreeBSD
Poller : cactid
Thold 3.0

johnrembo · Post by **johnrembo** » Wed Aug 30, 2006 2:21 am

I'm sorry i have left this patch unsupported for half a year (had been working on master's diploma).
I'll try to debug the problems you've reported and will let you know immediately...

Tekk · Post by **Tekk** » Wed Aug 30, 2006 2:38 am

Ok johnrembo, thanks.

johnrembo · Post by **johnrembo** » Wed Aug 30, 2006 6:33 am

Ok, here's the problem:
from thold 0.2.8 release input values are rounded up to four decimal places:

Code: Select all

$sql .= ", " . (trim($_POST["thold_hi"]) == "" ? "NULL" : ("'" . round($_POST["thold_hi"],4) . "'"));
$sql .= ", " . (trim($_POST["thold_low"]) == "" ? "NULL" : ("'" . round($_POST["thold_low"],4) . "'"));

this operation removes % sign which you do enter. in order precentage evaluation to work properly, this restriction has to be removed in all instances of thold-functions.php:

Code: Select all

$sql .= ", " . (trim($_POST["thold_hi"]) == "" ? "NULL" : ("'" . $_POST["thold_hi"] . "'"));
$sql .= ", " . (trim($_POST["thold_low"]) == "" ? "NULL" : ("'" . $_POST["thold_low"] . "'"));

similar problem exists in thold_templates.php where input values are checked against their numeric values.

download an attached patch and follow instructions.txt

if you fail to use precentage evaluation anyway - try to run check-thold.php manualy
# php check-thold.php
and post output here.

ps: thold_autocreate.diff.txt is not included in this patch
ps2: i'm encountering a notice in devices section "undefined index: hosts_status", but this doesn't seems to prevent Treshold listed devices Create function

Tekk · Post by **Tekk** » Wed Aug 30, 2006 12:43 pm

Hi johnrembo,

I cannot apply percentages to threshold templates but only when editing thresholds which are in the management category... Is it normal ?

johnrembo · Post by **johnrembo** » Thu Aug 31, 2006 5:54 am

no it isn't...
i've updated my previous post (in order not to confuse people). download the patch once again and try. In your case apply only thold_templates.diff.

I'm doing four programming tasks parallely

, so sorry for mistakes - I totally have no time for detailed debugging and appreciate your help.

Tekk · Post by **Tekk** » Thu Aug 31, 2006 8:02 am

Yeah good work, I really appreciate johnrembo. Thanks you very much !

Cacti

Thold precentage limits patch

Thold precentage limits patch

excuse

Who is online