BUG in Version 0.8.6h

[Brandoo]

Hey all!

Have just found Cacti today, installed the debian woody package and everything ran fine.

Soon found out that this version was quite old (0.8.6c I believe) so installed from the .tar.gz from the main Cacti site.

Not much worked well, and through trial/ error/ troubleshooting all is now up and running.

While sorting out all my issues I have found a bug (I believe).

My cacti.log file displayed the following errors:

03/17/2006 03:12:51 PM - CMDPHP: Poller[0] ERROR: SQL Cell Failed "select data_template_data.rrd_step from (data_template_da
ta,data_template_rrd,graph_templates_item) where graph_templates_item.task_item_id=data_template_rrd.id and data_template_rr
d.local_data_id=data_template_data.local_data_id and graph_templates_item.local_graph_id=11limit 0,1"

I jumped in to mysql and ran the query - but it wouldn't run due to a syntax error:

Code: Select all

11limit 0,1

should read

Code: Select all

11 limit 0,1

Looking for references to data_template_data.rrd_step I find the following in graph.php (code pasted starting from line 132)

Code: Select all

        /* find the step and how often this graph is updated with new data */
        $ds_step = db_fetch_cell("select
                data_template_data.rrd_step
                from (data_template_data,data_template_rrd,graph_templates_item)
                where graph_templates_item.task_item_id=data_template_rrd.id
                and data_template_rrd.local_data_id=data_template_data.local_data_id
                and graph_templates_item.local_graph_id=" . $_GET["local_graph_id"] .
                "limit 0,1");
        $ds_step = empty($ds_step) ? 300 : $ds_step;
        $seconds_between_graph_updates = ($ds_step * $rra["steps"]);

Once I put in the space before limit, all errors disappeard. The altered code is now:

Code: Select all

        /* find the step and how often this graph is updated with new data */
        $ds_step = db_fetch_cell("select
                data_template_data.rrd_step
                from (data_template_data,data_template_rrd,graph_templates_item)
                where graph_templates_item.task_item_id=data_template_rrd.id
                and data_template_rrd.local_data_id=data_template_data.local_data_id
                and graph_templates_item.local_graph_id=" . $_GET["local_graph_id"] .
                " limit 0,1");
        $ds_step = empty($ds_step) ? 300 : $ds_step;
        $seconds_between_graph_updates = ($ds_step * $rra["steps"]);

[rony]

Have you applied all the patches from the offical site?

[Brandoo]

Sorry - I feel like an idiot.

I did check all available patches, but the only one I saw was for MySQL Maximum Packet Size.

Have just checked again and found the patches under Cacti, and not cactid.

Sorry.