Cacti 0.8.6h Beta 4 - Final

[rony]

Here is beta 4 of 0.8.6h.

If you have the ability and time, please test the attached release of Cacti 0.8.6h. Please remember to test this in a NON-PRODUCTION environment.

Changes that where made for this planned release:

Code: Select all

Cacti CHANGELOG

0.8.6h
-bug#0000383: Add more verbose rrdtool debug output from Graph Management
-bug#0000522: Take 'oid_index_parse' into consideration when handling 'OID/REGEXP:' data query fields
-bug#0000528: Allow template_import.php to return without error when xml file is invalid in PHP 4.4 and above.
-bug#0000557: Changing filter value resulted in invalid page/row selection.
-bug#0000572: Added $database_port to config.php
-bug#0000570: Grammer edit for text about already up-to-date
-bug#0000571: Misleading diagnositc error messages during install have been updated
-bug#0000582: Ampersand present in graph template graph name causes xml import to fail
-bug#0000585: Graphing fails using AREA/STACK/LINE/HRULE/VRULE without defined color
-bug#0000586: Remove static reference to RRA ID #1
-bug#0000596: Proper excape of ' in graph titles
-bug#0000599: Add filtering to graphs and data templates
-bug#0000601: Add ability to add multiple hosts to a tree
-bug#0000603: user_log.ip field not ipv6 compatible
-bug#0000608: Minor coding error in lib/poller.php with a erroneous pclose statement
-bug#0000615: Minor host.php tweak
-bug#0000619: Host Templates not alphabetized on device creation form
-bug#0000625: Cannot modify/create a user with a period in the username
-bug#0000631: Invalid information concerning delimiter for index_order in SNMP Query documentation
-bug#0000650: Clicking Cancel in Create Graphs for this Host does nothing
-bug#0000656: Perl scripts using back ticks is not portable
-bug: Stop MySQL connect messages from appearing in user interface
-bug: Allow primary keys other than "ID" to work in sql_save and in HTML code
-bug: Save statistics even when the poller times out.
-bug: Only call poller_commands.php or poller_export.php if they require calling.
-bug: Incorporate a timeout to ss_fping.php so that a host that takes to long to finish at least returns data
-bug: Correct the display of custom data in data input methods to follow the proper order
-bug: Change the default behavior of ping.php to mark a host as up if either snmp or ping are successful.
-bug: Don't allow graph_export to delete your web site.
-bug: Correct issue where snmp was not returning both hex and text data under certain circumstances.
-bug: Prevent a never ending table lock in lib/tree.php
-bug: Correct issue where either AREA or LINEx without color were causing RRD_NL without any elements in rrdtool_graph.
-bug: Allow hostname to include the TCP: prefix for TCP based snmp and keep tcp, icmp, udp ping functional
-bug: Better error reporting for Clear Cacti Log File in Utilties
-bug: Graphs with items having Legend text defined but no color will fail under rrdtool 1.2.x
-feature: MySQL 5.x support
-feature: Add IPv6 support to lib/ping.php
-feature: When utilizing cmd.php, don't run the script_server if it is not required for a process.
-feature: Incorporate snmpbulkwalk binary path to user interface to speed snmpv2 & snmpv3 walk calls.
-feature: Incorporate snmpgetnext binary path to user interface to make available for certain plugins.
-feature; Now have support for Nth percentile functions, not just 95th.
-feature: Added support for new Nth Percentile Variables: aggregate, aggregate_max, aggregate_sum
-feature: Allow additional filtering for graph item adding while creating graphs
-feature: Command line script to copy users: copy_cacti_user.php
-feature: Command line script to reindex hosts: poller_reindex_hosts.php
-feature: Command line script to rebuild the poller cache: rebuild_poller_cache.php

Also note:

Code: Select all

A Note About RRDtool:

RRDTool is available in 2 versions, 1.0.x and 1.2.x, both are supported
by Cacti.  Please remember to confirm your Cacti settings for the RRDtool
version if you having problem rendering graphs.

Also important to note in version Cacti 0.8.6h and above, graph items with
no color assigned are now properly presented to RRDTool.  The upgraded
will fix graph items that will cause your graphs not to render, but as
always, please remember to backup before you proceed to upgrade.

[cigamit]

I've thrown it on my test box, and eveything seems to be running fine except this one error.

Code: Select all

12/30/2005 12:51:10 AM - CMDPHP: Poller[0] ERROR: SQL Assoc Failed "select user_auth_realm.user_id, user_realm.id, user_realm.name from user_realm left join user_auth_realm on (user_realm.id=user_auth_realm.realm_id and user_auth_realm.user_id=0) order by user_realm.name"

MySQL throws back this error when ran manually

Code: Select all

ERROR 1146 (42S02): Table 'cacti.user_realm' doesn't exist

Which is caused by the code on line 530 of user_admin.php.

Code: Select all

	$realms = db_fetch_assoc("select
		user_auth_realm.user_id,
		user_realm.id,
		user_realm.name
		from user_realm
		left join user_auth_realm on (user_realm.id=user_auth_realm.realm_id and user_auth_realm.user_id=" . (empty($_GET["id"]) ? "0" : $_GET["id"]) . ")
		order by user_realm.name");

Which doesn't appear to be used at this point (and doesn't seem to have migrated from the "trunk" branch).

Plugins still work perfectly after patching, so no problem there. And Yes, I pretty much never sleep.

EDIT: This seems to have been in place for a very long time, and it doesn't seem that anyone else has noticed it before, strange. It should have probably been removed by this Commit back in 2003. Anyways, can't find any other issues as of yet.

Revision: 1251
Author: iberry
Date: 2:08:03 AM, Thursday, October 09, 2003
Message:
get rid of the 'user_realm' and 'user_realm_filename' tables and replace them with arrays
----
Modified : /trunk/cacti/include/auth.php
Modified : /trunk/cacti/include/config_arrays.php
Modified : /trunk/cacti/user_admin.php

[rony]

Why are you mixing 0.8.6h with 0.9.0 trunk stuff?

Did you get this error with this file? Did you load the sql included with this file?

[cigamit]

Why are you mixing 0.8.6h with 0.9.0 trunk stuff?

Did you get this error with this file? Did you load the sql included with this file?

Nope, not mixing with the trunk stuff, using only the package you provided above. I get the error anytime I add a new user or edit a user (and click Save) using Logging Level LOW.

----

You can really ignore the SVN log comment I posted. I just used it as a little research to see when this code was added, and when the user_realm table disappeared. It shows the file as /trunk/cacti/user_admin.php because it was added and looks like it should have been removed long before there was ever a branch BRANCH_0_8_6 in CVS / SVN.

[rony]

Um....

Those arrays have been there a long time. So no affect, and yes I ignored it shortly after I read it.

I have reposted the beta files, because I found an issue with the install script.

I was able to add a user, nothing, I repeat, nothing has changed with the user management code from 0.8.6g. So, I'm concerned that you have not properly installed it.

[TheWitness]

posting just to keep me posted...

[cigamit]

OK, I will go through the steps, point out anything that may be wrong.

Installing on a test machine running CentOS 4.1, complete fresh install using the re-downloaded v0.8.6h package. Untarred the package to /var/www/html/ which is the root of the web server.

Ran these commands

Code: Select all

mysqladmin create cacti
mysql -u root -p cacti < /var/www/html/cacti.sql
mysql -e "GRANT ALL ON cacti.* TO cactiuser@localhost IDENTIFIED BY 'cactiuser'"
mysql -e "flush privileges"

I properly setup the cron jobs (not that it matters much for all intensive purposes, just polling)
I open Firefox and goto http://MACHINEIP/ which redirects me to http://MACHINEIP/install/
I click NEXT, it asks me whether its a new install or Upgrade, New Install is already selected so I click NEXT. It successfully finds all the necessary executables, and the correct Net-SNMP / RRDTool versions. I click Finish.

I now login as admin, and change the password. I immediately goto "User Management" and click on the admin user. I then just click the SAVE button. I then immediately goto "System Utilities" and click on "View Cacti Log File". I now have 2 items in it.

Code: Select all

 12/30/2005 11:35:29 AM - CMDPHP: Poller[0] ERROR: SQL Assoc Failed "select user_auth_realm.user_id, user_realm.id, user_realm.name from user_realm left join user_auth_realm on (user_realm.id=user_auth_realm.realm_id and user_auth_realm.user_id=1) order by user_realm.name"
12/30/2005 11:35:02 AM - SYSTEM STATS: Time:1.1104 Method:cmd.php Processes:1 Threads:N/A Hosts:2 HostsPerProcess:2 DataSources:5 RRDsProcessed:5

I do realise that the user management code has not changed since G, which is why I said its strange no one else ever caught the error. But if you open user_admin.php and goto line 530 and look at the SQL statement, its fairly clear that it references user_realm.id and user_realm.name but yet in cacti.sql there is no table user_realm.

In install/0_8_3_to_0_8_4.php the first line of code is this

Code: Select all

db_install_execute("0.8.4", "DROP TABLE `user_realm`;");

so that will show you how long ago this table went away.

[rony]

Wow....

You found what could possibly be the longest bug to never get fixed in cacti.

I have updated SVN, because this really doesn't affect how cacti works, it was just an extra SQL query that didn't need to be executed.

[rony]

Release of 0.8.6h is being proceessed.

[TheWitness]

I can hear the virtual teletype chattering away processing the release as I sit here in the data center twidling my thumbs.

Larry

[Instigater]

confirming

Code: Select all

-bug#0000586: Remove static reference to RRA ID #1

resolved