How to do the patch with 0.8.6f version ?

[mobbylin]

I had installed the 0.8.6f on Linux. Now I try to down the new patch by using the command

wget http://www.cacti.net/downloads/patches/ ... itle.patch

Then I use the guide to perform the patch
--------------------------------
patch -p1 -N < html_mouseover_title.patch patching file data_sources.php
The result as below:
Hunk #1 FAILED at 1045.
1 out of 1 hunk FAILED -- saving rejects to file data_sources.php.rej
patching file graphs.php
Hunk #1 FAILED at 1087.
1 out of 1 hunk FAILED -- saving rejects to file graphs.php.rej
[root@linux cacti-0.8.6f]#
----------------------------------------
What's wrong with my environment? I try to use the account, root and cactiuser, all fail to do so. I list the rej file as below:
[root@linux cacti-0.8.6f]# ls -l *.rej
-rw-r--r-- 1 root root 1396 Aug 9 14:57 data_sources.php.rej
-rw-r--r-- 1 root root 1391 Aug 9 14:57 graphs.php.rej

Who can help me? Thanks.

Etan.

[rony]

Do you have any addon's applied? Threshold, Cactihistory, monitor, etc?

Can you email/pm me the "rej" files?

[mobbylin]

I just install thold


data_sources.php.rej
***************
*** 1045,1051 ****
form_alternate_row_color($colors["alternate"],$colors["light"],$i); $i++;
?>
<td>
- <a class='linkEditMain' href='data_sources.php?action=ds_edit&id=<?php print $data_source["local_data_id"];?>'><?php if ($_REQUEST["filter"] != "") { print eregi_replace("(" . preg_quote($_REQUEST["filter"]) . ")", "<span style='background-color: #F8D93D;'>\\1</span>", title_trim($data_source["name_cache"], read_config_option("max_title_data_source"))); }else{ print title_trim($data_source["name_cache"], read_config_option("max_title_data_source")); } ?></a>
</td>
<td>
<?php print $data_source["data_input_name"];?>
--- 1045,1051 ----
form_alternate_row_color($colors["alternate"],$colors["light"],$i); $i++;
?>
<td>
+ <a class='linkEditMain' href='data_sources.php?action=ds_edit&id=<?php print $data_source["local_data_id"];?>' title='<?php print $data_source["name_cache"];?>'><?php if ($_REQUEST["filter"] != "") { print eregi_replace("(" . preg_quote($_REQUEST["filter"]) . ")", "<span style='background-color: #F8D93D;'>\\1</span>", title_trim($data_source["name_cache"], read_config_option("max_title_data_source"))); }else{ print title_trim($data_source["name_cache"], read_config_option("max_title_data_source")); } ?></a>
</td>
<td>
<?php print $data_source["data_input_name"];?>
------------------------------------

graphs.php.rej
---------------------------------------------------------------------------
***************
*** 1087,1093 ****
form_alternate_row_color($colors["alternate"],$colors["light"],$i); $i++;
?>
<td>
- <a class="linkEditMain" href="graphs.php?action=graph_edit&id=<?php print $graph["local_graph_id"];?>"><?php if ($_REQUEST["filter"] != "") { print eregi_replace("(" . preg_quote($_REQUEST["filter"]) . ")", "<span style='background-color: #F8D93D;'>\\1</span>", title_trim($graph["title_cache"], read_config_option("max_title_graph"))); }else{ print title_trim($graph["title_cache"], read_config_option("max_title_graph")); } ?></a>
</td>
<td>
<?php print ((empty($graph["name"])) ? "<em>None</em>" : $graph["name"]); ?>
--- 1087,1093 ----
form_alternate_row_color($colors["alternate"],$colors["light"],$i); $i++;
?>
<td>
+ <a class="linkEditMain" href="graphs.php?action=graph_edit&id=<?php print $graph["local_graph_id"];?>" title="<?php print $graph["title_cache"];?>"><?php if ($_REQUEST["filter"] != "") { print eregi_replace("(" . preg_quote($_REQUEST["filter"]) . ")", "<span style='background-color: #F8D93D;'>\\1</span>", title_trim($graph["title_cache"], read_config_option("max_title_graph"))); }else{ print title_trim($graph["title_cache"], read_config_option("max_title_graph")); } ?></a>
</td>
<td>
<?php print ((empty($graph["name"])) ? "<em>None</em>" : $graph["name"]); ?>

[rony]

That would be why these patches failed.

We, the developers, can not guarantee that patches work with addons installed. My suggestion is install patches, then thold.