Thold graph view Number of Row, dosen't match the presentend line

[Rno]

Hello,
I did some clean up of my monitored link, and now my count of number of breached Threshold dosen't match the displayed line.

I have 18 On the top:
All 18 Thresholds


But only 17 displayed.

If I do a simple query like that on my DB:

Code: Select all

SELECT * FROM `thold_data` AS td where (td.thold_enabled = 'on' AND ((td.thold_alert != 0 OR td.bl_alert > 0)) ) 

I got 17 rows.

And I'm administrator, so i't not a issue about user name.

It's on cacti 1.2.25, and I uprade Thold this morning.

EDIT:
It's look like it's only happening when I select the status Breached
When I select triggered, the count is correct.

[TheWitness]

Keep us posted.

[Rno]

So looking deeper on this I have some question:
On thold_graph.php, under 'function tholds'
line 329 and below:

Code: Select all

		'status' => array(
			'filter' => FILTER_VALIDATE_INT,
			'pageset' => true,
			'default' => $default_status

But on the URL you only use state, not status
/cacti/plugins/thold/thold_graph.php?action=thold&state=1&thold_template_id=-1&data_template_id=-1&host_id=-1&site_id=-1&rows=-1&rfilter=

So how the filter in line 356-365 suppose to work ?

Code: Select all

	/* status filter */
	if (get_request_var('status') == '-1') {
		/* return all rows */
	} else {
		if (get_request_var('status') == '0') { $sql_where = "(td.thold_enabled = 'off'"; } /*disabled*/
		if (get_request_var('status') == '2') { $sql_where = "(td.thold_enabled = 'on'"; } /* enabled */
		if (get_request_var('status') == '1') { $sql_where = "(td.thold_enabled = 'on' AND ((td.thold_alert != 0 OR td.bl_alert > 0))"; } /* breached */
		if (get_request_var('status') == '3') { $sql_where = "(td.thold_enabled = 'on' AND (((td.thold_alert != 0 AND td.thold_fail_count >= td.thold_fail_trigger) OR (td.bl_alert > 0 AND td.bl_fail_count >= td.bl_fail_trigger)))"; } /* status */
		if (get_request_var('status') == '4') { $sql_where = "(td.acknowledgment = 'on'"; } /* status */
	}

Then I will go further after that.
thanks

[Rno]

Damn I was looking of the old code.

But still the error is present in production, but my research where in the wrong version!

My synchro between my serveur and my desktop is way not ptimize

Will have to fix this

[TheWitness]

Di you open a bug in GitHub?