Error on Thold after cleanup

[Rno]

Hello again,
I did some clean up of my link, mostly remove graph on interface that are no longer in used.

And Since I got some error like that on my log:

Code: Select all

02/11/2023 15:06:12 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[780]:process_poller_output(), /lib/poller.php[805]:api_plugin_hook_function(), /lib/plugins.php[155]:api_plugin_run_plugin_hook_function(), /lib/plugins.php[276]:thold_poller_output(), /plugins/thold/includes/polling.php[177]:thold_calculate_expression(), /plugins/thold/thold_functions.php[904]:get_current_value(), /plugins/thold/thold_functions.php[4706]:CactiErrorHandler())
02/11/2023 15:06:12 - ERROR PHP NOTICE in Plugin 'thold': Trying to access array offset on value of type null in file: /usr/share/cacti/plugins/thold/thold_functions.php on line: 4706
02/11/2023 15:06:12 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[780]:process_poller_output(), /lib/poller.php[805]:api_plugin_hook_function(), /lib/plugins.php[155]:api_plugin_run_plugin_hook_function(), /lib/plugins.php[276]:thold_poller_output(), /plugins/thold/includes/polling.php[177]:thold_calculate_expression(), /plugins/thold/thold_functions.php[904]:get_current_value(), /plugins/thold/thold_functions.php[4706]:CactiErrorHandler())
02/11/2023 15:06:12 - ERROR PHP NOTICE in Plugin 'thold': Undefined index: values in file: /usr/share/cacti/plugins/thold/thold_functions.php on line: 4706
02/11/2023 15:06:12 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[780]:process_poller_output(), /lib/poller.php[805]:api_plugin_hook_function(), /lib/plugins.php[155]:api_plugin_run_plugin_hook_function(), /lib/plugins.php[276]:thold_poller_output(), /plugins/thold/includes/polling.php[177]:thold_calculate_expression(), /plugins/thold/thold_functions.php[904]:get_current_value(), /plugins/thold/thold_functions.php[4706]:CactiErrorHandler())
02/11/2023 15:06:12 - ERROR PHP NOTICE in Plugin 'thold': Trying to access array offset on value of type null in file: /usr/share/cacti/plugins/thold/thold_functions.php on line: 4706
02/11/2023 15:06:12 - CMDPHP PHP ERROR NOTICE Backtrace: (/poller.php[780]:process_poller_output(), /lib/poller.php[805]:api_plugin_hook_function(), /lib/plugins.php[155]:api_plugin_run_plugin_hook_function(), /lib/plugins.php[276]:thold_poller_output(), /plugins/thold/includes/polling.php[177]:thold_calculate_expression(), /plugins/thold/thold_functions.php[904]:get_current_value(), /plugins/thold/thold_functions.php[4706]:CactiErrorHandler())
02/11/2023 15:06:12 - ERROR PHP NOTICE in Plugin 'thold': Undefined index: values in file: /usr/share/cacti/plugins/thold/thold_functions.php on line: 4706

How Can I clean up the threshold to be sure they have a graph linked to it ?

Thanks

[TheWitness]

Hey Rno,

Is this the latest develop of thold? I'm still trying to find time to get it released.

[Rno]

Hello,
Yes the one I upload the 2nd november.

[TheWitness]

Never mind, change 4704 to this:

Code: Select all

if (!isset($result['values']) || $idx === null || !cacti_sizeof($result['values'][$idx])) {

[TheWitness]

Kind of hack this in for now. I'm still working on a commit that's a bit larger. I might be able to merge this shortly, it just depends on what I have to toss out locally

[TheWitness]

I just pushed the change still holding back everything else.

[Rno]

Hello,
So I upgrade my thold with the latest dev branch, and it's working fine now.
thanks.