Threshold crashing after update to 1.2.23

[hipsterdoofus]

Hey all,

I updated to 1.2.23 yesterday. I am running thold 1.6, but after it runs briefly, it crashes with the following errors. I've re-installed thold and tried to check everything I can think of but it is still crashing. I can provide other information needed, but this is what is showing up in my logs - I appreciate your assistance:

2023/01/25 09:45:29 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'thold'
2023/01/25 09:45:29 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler())
2023/01/25 09:45:29 - ERROR PHP ERROR in Plugin 'thold': Uncaught DivisionByZeroError: Division by zero in /var/www/html/cacti-1.2.23/plugins/thold/thold_functions.php:3742 Stack trace: #0 /var/www/html/cacti-1.2.23/plugins/thold/thold_functions.php(2256): thold_format_number() #1 /var/www/html/cacti-1.2.23/plugins/thold/includes/polling.php(441): thold_check_threshold() #2 /var/www/html/cacti-1.2.23/plugins/thold/includes/polling.php(47): thold_check_all_thresholds() #3 /var/www/html/cacti-1.2.23/lib/plugins.php(225): thold_poller_bottom() #4 /var/www/html/cacti-1.2.23/lib/plugins.php(83): api_plugin_run_plugin_hook() #5 /var/www/html/cacti-1.2.23/poller.php(825): api_plugin_hook() #6 {main} thrown in file: /var/www/html/cacti-1.2.23/plugins/thold/thold_functions.php on line: 3742

[TheWitness]

Are you running the develop thold?

[hipsterdoofus]

It may be. In cacti under plugs it shows version 1.6.

[TheWitness]

How did you download and install it? How long ago was that?

[TheWitness]

I also just committed this.

https://github.com/Cacti/plugin_thold/c ... 3fee177e4f

[hipsterdoofus]

It was Tuesday and I tried again Yesterday to do it again.

[TheWitness]

Okay, that fix should fix the issue.

[hipsterdoofus]

That does appear to have fixed it. Thanks so much!