Upgrading to 1.2.17 - Does this look right?

[mchorsley]

Hi,

I'm in the process of upgrading Cacti from 1.2.16 to 1.2.17. The upgrade has so far been running for 2 hours and it's still at 3%. I know it can take some time to complete, but the install seems to be looping:

Code: Select all

[2021-05-27 11:14:45] [          global always  ] Spawning background process: /bin/php '/usr/share/cacti/install/background.php' 1622110485.0356
[2021-05-27 11:14:45] [          global always  ] Setting PHP Option max_execution_time = 0
[2021-05-27 11:14:45] [          global always  ] Setting PHP Option memory_limit = -1
[2021-05-27 11:14:45] [          global always  ] Starting UPGRADE Process for v1.2.17
[2021-05-27 11:14:45] [          global always  ] No tables where found or selected for conversion
[2021-05-27 11:14:45] [          global always  ] Switched from /tmp/cdu0kdGin to /tmp/cdu7wDIVx
[2021-05-27 11:14:45] [          global always  ] NOTE: Using temporary file for db cache: /tmp/cdu7wDIVx
[2021-05-27 11:14:45] [          global always  ] Upgrading from v1.2.16 (DB 1.2.17 (DB: 1.2.16)) to v1.2.17

Screenshot 2021-05-27 at 11.31.11.png (734.02 KiB) Viewed 4419 times

Should I be more patient?

Thanks

[mchorsley]

OK, so I think I've found the issue:

Code: Select all

+++PHP Fatal error:  Uncaught ArgumentCountError: array_key_exists() expects exactly 2 arguments, 3 given in /usr/share/cacti/install/upgrades/1_2_17.php:176
Stack trace:
#0 /usr/share/cacti/install/upgrades/1_2_17.php(176): array_key_exists('aggregate_graph...', Array, true)
#1 /usr/share/cacti/install/upgrades/1_2_17.php(54): database_fix_mediumint_columns()
#2 /var/lib/cacti/cli/upgrade_database.php(129): upgrade_to_1_2_17()
#3 {main}
  thrown in /usr/share/cacti/install/upgrades/1_2_17.php on line 176

Changing cacti/install/upgrades/1_2_17.php:176

Code: Select all

if (!array_key_exists($table, $tables, true)) {

to

Code: Select all

if (!array_key_exists($table, $tables)) {

and cacti/install/upgrades/1_2_17.php:183

Code: Select all

if (array_key_exists($field, $known_columns, true)) {

to

Code: Select all

if (array_key_exists($field, $known_columns)) {

Then running

Code: Select all

$ php upgrade_database.php --debug

Results in a successful DB upgrade

[netniV]

I am not sure if this was you, but someone posted a pull request for fixing this on our GitHub Repo recently. It's now a known issue.

[mchorsley]

Yes, that was me. Issue #4284 (fixed in the 1.2.x branch)