Database upgrade error on the v1.0.5 step

[rolandbreedveld]

I'm upgrading Cacti from from v0.8.8b to v1.2.2
every goes well until the "Upgrading from v1.0.4 (DB 1.0.4) to v1.0.5" step:
UPDATE data_template_data SET data_source_profile_id = WHERE data_source_profile_id = 0 [Fail]
the should be a value after "data_source_profile_id ="
running on raspberry Pi "buster"
installed cacti version: 1.2.2

in the /usr/share/cacti/site/install/upgrades/1_0_5.php:

/* bad data source profile id's */
$profile_id = db_fetch_cell('SELECT id FROM data_source_profiles ORDER BY `default` DESC LIMIT 1');
db_install_execute('UPDATE data_template_data SET data_source_profile_id = ' . $profile_id . ' WHERE data_source_profile_id = 0');

my table data_source_profiles is empty, so there it's going wrong
in the original v.0.8.8b version the table "data_source_profiles" doesn't exist
so I removed these lines, after this the upgrade went fine.

Anybody know if I can expect problems with this?

[Osiris]

Believe it or not, there have been a number of changes post 1.2.2 to the installer to compensate for such things. Better to simply in your production environment, goto 1.2.11 once released.