graphs_view.php broken in dual pane tree view

Post support questions that relate to the Windows 2003/2000/XP operating systems.

Moderators: Developers, Moderators

jmjones
Posts: 18
Joined: Wed Feb 09, 2005 12:19 pm

Here is some patchwork for your code

Post by jmjones »

If you are having the pesky error that I have been referring to in this post. I have altered a section of code found in include/top_graph_header.php

The code block is as follows
$first_branch = find_first_folder_url();
if (!empty($first_branch)) {
if(!empty($_REQUEST["ret"])){
$mystring = "&ret=yes";
$first_branch = $first_branch . $mystring;
header("Location: $first_branch");
}
print "The first branch was not empty" .$first_branch;
}

All it does is keep track of whether or not it is looping by throwing a var in the querystring

Hope this helps

Jason :wink:
User avatar
TheWitness
Developer
Posts: 17007
Joined: Tue May 14, 2002 5:08 pm
Location: MI, USA
Contact:

Post by TheWitness »

Does this problem only manifest itself when "Expand Hosts" is selected from "Graph Settings"?

TheWitness
True understanding begins only when we realize how little we truly understand...

Life is an adventure, let yours begin with Cacti!

Author of dozens of Cacti plugins and customization's. Advocate of LAMP, MariaDB, IBM Spectrum LSF and the world of batch. Creator of IBM Spectrum RTM, author of quite a bit of unpublished work and most of Cacti's bugs.
_________________
Official Cacti Documentation
GitHub Repository with Supported Plugins
Percona Device Packages (no support)
Interesting Device Packages


For those wondering, I'm still here, but lost in the shadows. Yearning for less bugs. Who want's a Cacti 1.3/2.0? Streams anyone?
jmjones
Posts: 18
Joined: Wed Feb 09, 2005 12:19 pm

Initial testing conclusions

Post by jmjones »

I have replaced my code with the code in the distribution, and found that there was no difference when I enabled the expand hosts option.
jmjones
Posts: 18
Joined: Wed Feb 09, 2005 12:19 pm

I spoke too soon

Post by jmjones »

There is an error message when the expand hosts option is enabled.
"CGI Error
The specified CGI application misbehaved by not returning a complete set of HTTP headers."

real helpful error message don't you think. I haven't a clue what causes this, but the code I submitted earlier fixes this issue as well.
User avatar
rony
Developer/Forum Admin
Posts: 6022
Joined: Mon Nov 17, 2003 6:35 pm
Location: Michigan, USA
Contact:

Post by rony »

Sending myself a note to explore you patch.

Thanks for working on it!
[size=117][i][b]Tony Roman[/b][/i][/size]
[size=84][i]Experience is what causes a person to make new mistakes instead of old ones.[/i][/size]
[size=84][i]There are only 3 way to complete a project: Good, Fast or Cheap, pick two.[/i][/size]
[size=84][i]With age comes wisdom, what you choose to do with it determines whether or not you are wise.[/i][/size]
User avatar
TheWitness
Developer
Posts: 17007
Joined: Tue May 14, 2002 5:08 pm
Location: MI, USA
Contact:

Post by TheWitness »

Tony,

Please crank out a patch. Need it deparately.

Larry

:P
True understanding begins only when we realize how little we truly understand...

Life is an adventure, let yours begin with Cacti!

Author of dozens of Cacti plugins and customization's. Advocate of LAMP, MariaDB, IBM Spectrum LSF and the world of batch. Creator of IBM Spectrum RTM, author of quite a bit of unpublished work and most of Cacti's bugs.
_________________
Official Cacti Documentation
GitHub Repository with Supported Plugins
Percona Device Packages (no support)
Interesting Device Packages


For those wondering, I'm still here, but lost in the shadows. Yearning for less bugs. Who want's a Cacti 1.3/2.0? Streams anyone?
User avatar
rony
Developer/Forum Admin
Posts: 6022
Joined: Mon Nov 17, 2003 6:35 pm
Location: Michigan, USA
Contact:

Post by rony »

jmjones,

Ok, well after review of the current code, the session variable

Code: Select all

$_SESSION["sess_has_viewed_graphs"]
takes care of if the redirection happens again. This would lead me to believe that you maybe having a cookie or session problem. I only see one redirect when I sniff traffic when viewing the graph page initially. Btw, was using the database you sent me a while ago to test, so I have the same hosts.

Larry, this is not the solution to the issue with the graph page being slow, so I don't see a patch at this time.
[size=117][i][b]Tony Roman[/b][/i][/size]
[size=84][i]Experience is what causes a person to make new mistakes instead of old ones.[/i][/size]
[size=84][i]There are only 3 way to complete a project: Good, Fast or Cheap, pick two.[/i][/size]
[size=84][i]With age comes wisdom, what you choose to do with it determines whether or not you are wise.[/i][/size]
User avatar
TheWitness
Developer
Posts: 17007
Joined: Tue May 14, 2002 5:08 pm
Location: MI, USA
Contact:

Post by TheWitness »

:cry:
True understanding begins only when we realize how little we truly understand...

Life is an adventure, let yours begin with Cacti!

Author of dozens of Cacti plugins and customization's. Advocate of LAMP, MariaDB, IBM Spectrum LSF and the world of batch. Creator of IBM Spectrum RTM, author of quite a bit of unpublished work and most of Cacti's bugs.
_________________
Official Cacti Documentation
GitHub Repository with Supported Plugins
Percona Device Packages (no support)
Interesting Device Packages


For those wondering, I'm still here, but lost in the shadows. Yearning for less bugs. Who want's a Cacti 1.3/2.0? Streams anyone?
User avatar
rony
Developer/Forum Admin
Posts: 6022
Joined: Mon Nov 17, 2003 6:35 pm
Location: Michigan, USA
Contact:

Post by rony »

Sorry man, still searching for the badness in the code.... :-?
[size=117][i][b]Tony Roman[/b][/i][/size]
[size=84][i]Experience is what causes a person to make new mistakes instead of old ones.[/i][/size]
[size=84][i]There are only 3 way to complete a project: Good, Fast or Cheap, pick two.[/i][/size]
[size=84][i]With age comes wisdom, what you choose to do with it determines whether or not you are wise.[/i][/size]
dj_seijin
Posts: 7
Joined: Tue Mar 15, 2005 9:25 am

Hown can i solve this problem?

Post by dj_seijin »

Hi people,,, i want to know if only changing the timeout on php.ini the dual pane will working correctly??...

Regards... :roll: :roll: :roll:
jmjones
Posts: 18
Joined: Wed Feb 09, 2005 12:19 pm

Maybe, maybe not

Post by jmjones »

This error is kind of tricky, changing the timeouts may help - they have for some. Tell what server makeup you have and you will get more help. I have been battling this problem in win 2k3, php4 and mysql4. My server is very fast and I think that has something to do with it. Does your server have multiple processors? Mine does.
User avatar
rony
Developer/Forum Admin
Posts: 6022
Joined: Mon Nov 17, 2003 6:35 pm
Location: Michigan, USA
Contact:

Post by rony »

It helps, with largers installations. ;)

It's just masking a larger issue that I'm trying to find the time to fix. :)
[size=117][i][b]Tony Roman[/b][/i][/size]
[size=84][i]Experience is what causes a person to make new mistakes instead of old ones.[/i][/size]
[size=84][i]There are only 3 way to complete a project: Good, Fast or Cheap, pick two.[/i][/size]
[size=84][i]With age comes wisdom, what you choose to do with it determines whether or not you are wise.[/i][/size]
dj_seijin
Posts: 7
Joined: Tue Mar 15, 2005 9:25 am

issueeeeeeeeeee...!!! :S

Post by dj_seijin »

I have 2 differents severs in linux with cacti 8.6c(probe)
in one of the servers(ServerA) the dual pane work perfect..
And in the other server not work..
I take the same tar.gz for installation.

Server A:
Red Hat Linux Advanced Server
Apache/1.3.23
mysql Ver 11.15 Distrib 3.23.41, for redhat
2 - cpu - Intel PIII 1.2 GHz

Server B:
Fedora Core release 2
Apache/2.0.51
mysql Ver 11.18 Distrib 3.23.58, for redhat
2 - cpu - Intel(R) Xeon 2.4Ghz
dj_seijin
Posts: 7
Joined: Tue Mar 15, 2005 9:25 am

Frontend

Post by dj_seijin »

I put a frontend to access my internal cacti (ServerA )and i can see the dual pane...
Im really confuse where is the problem!

:-? :-? :-?
jmjones
Posts: 18
Joined: Wed Feb 09, 2005 12:19 pm

You are getting caught in a redirection error

Post by jmjones »

Look at the code snippet I suggested above. If you are familiar with php, comment out the original code and insert the snippet from above. Let me know if that works for you. Also, someone else suggested that there may be an issue with the "Expand Hosts" option. You may want to try different variations of this option. Make sure that when you make a change that you close your browser out. This will make sure that all of the server variables will be "Nulled Out" and you can get an accurate idea of what changes did work and what changes didn't

As I say, I am still looking for a "Better Solution" to this problem, but to get that I need to find where the problem really is. Please share all the information that you discover so a proper patch can be created.

Roni and The Witness rule. 8) They will save the day, I just know it--- Right???
Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest