Cacti 1.1.10 - 1.1.20 SQL query upgrade error

[jround]

During an upgrade from Cacti 1.1.10 to Cacti 1.1.20 everything goes OK apart from the below SQL query error :-

[Fail] 
ALTER TABLE snmpagent_cache_textual_conventions
MODIFY COLUMN name VARCHAR(50) NOT NULL,
MODIFY COLUMN mib VARCHAR(50) NOT NULL,
MODIFY COLUMN type VARCHAR(50) NOT NULL,
PRIMARY KEY (`name`,`mib`,`type`)

I have rolled the server back (VM snapshot) for now so no harm done but any ideas how to resolve?

[Rno]

It's a known problem, the ADD is missing
the right command should be:

ALTER TABLE snmpagent_cache_textual_conventions
MODIFY COLUMN name VARCHAR(50) NOT NULL,
MODIFY COLUMN mib VARCHAR(50) NOT NULL,
MODIFY COLUMN type VARCHAR(50) NOT NULL,
ADD PRIMARY KEY (`name`,`mib`,`type`)

[majedz]

ok i executed the right command in the cacti database;
or should it be done in all the databases?

[Rno]

Just the cacti one

[JJX]

Same problem here (after testing 0.8.8h to 1.1.20)
Solved with:

MariaDB [cacti]> ALTER TABLE snmpagent_cache_textual_conventions
-> MODIFY COLUMN name VARCHAR(50) NOT NULL,
-> MODIFY COLUMN mib VARCHAR(50) NOT NULL,
-> MODIFY COLUMN type VARCHAR(50) NOT NULL,
-> ADD PRIMARY KEY (`name`,`mib`,`type`)
-> ;
Query OK, 2 rows affected (0.51 sec)
Records: 2 Duplicates: 0 Warnings: 0


Thank you

[Osiris]

Fixed in 1.1.21