Change to take interface status make it works

[Rno]

I thing there was a request to change the REGEXP_SNMP_TRIM into snmp.php to be able to query the interface status long time ago, and still not changed !

Is it planed to do it in a future release ?
And it will not change the functionallity of snmp.php

It will change for the following value:
define("REGEXP_SNMP_TRIM", "/(hex|counter(32|64)|gauge|gauge(32|64)|float|ipaddress|string|integer):|(up|down)\(|\)$/i");


and changing the interface.xml the following way will alos solve the issue:
<ifOperStatus>
<name>Status</name>
<method>walk</method>
<source>VALUE/REGEXP:[a-zA-Z]{1,}\(([1-]{1})+\)$</source>
<direction>output</direction>
<oid>.1.3.6.1.2.1.2.2.1.8</oid>
</ifOperStatus>

Source and direction

thanks

[Osiris]

Two words "pull request"

[Rno]

One quick question, In a pool request, should just put the code I propose to change, or can I do more ?
Text of explanation of what to do or whatever.

Sorry to ask that but I'm willing to do it, but need to be sure of what I'm doing !

[Osiris]

Look at some of the dozens that have been logged and committed already.

[Rno]

Well I try to create one, but so far I just add some comment, and I can find 4 files on my pull request
Bu none of then where added by my

Sorry, but I'm not an expert of githut, and I can't find any help on it !!
I'm not even sure the base is master, the compare is develop!
So looking at all that where done before, dosen't help of how to do it!!


Any help to help will be nice

[Osiris]

Well one day you will move from your 'githut' to a real live GitHub. Wait for you moment, and make it happen.

[Rno]

After 3 tests, i was able to do it,
and the 2 changes proposed where accepted.

I'm not sur I can't say thanks for the help !!