nectar report items using tree type not always work

[jeffpage]

nectar report : items using tree type not always work .
after selecting tree and tree branch node .
and whether choosing Cascade to Branches or not .
the report preview will not always show what branch I select .
how to tracking this kind of problem ,any idea ?

[TheWitness]

What version is this? 0.35a?

[jeffpage]

yes I have upgrade to cacti 0.8.7h with nectar version 0.35a
by the way I also choose ithems by graphs one by one, it works fine ,but it is very inconvenient the way when I need lots of graph in a branch or in a node

[alvarino]

I'm facing the same problem after upgrade from Nectar 0.28b to 0.35a.

Cacti version 0.8.7g.

Installed plugins:
* Settings: 0.7
* Nectar
* PIA: 2.8

[cpttab311]

Hi, same issue.

I've recently upgraded to 0.88a and nectar 0.35a with settings 0.71.

My Nectar reports that are built with individual graphs work fine, however any reports built via tree are broken (ie. the graphs simply don't appear).

Has anyone identified the problem?

[cpttab311]

Anyone have any other input on this issue? Any fixes? I see nectar is still on 0.35a. Hoping other people have had some luck.

Thanks!

Hi, same issue.

I've recently upgraded to 0.88a and nectar 0.35a with settings 0.71.

My Nectar reports that are built with individual graphs work fine, however any reports built via tree are broken (ie. the graphs simply don't appear).

Has anyone identified the problem?

[gandalf]

Please post your exact settings for that very report. I'll try to reproduce the issue
R.

[cpttab311]

Hi Gandalf -

Here's a screenshot of my exact settings.

[gandalf]

after selecting tree and tree branch node .
and whether choosing Cascade to Branches or not .

- it's a tree problem
- it occures only, when selecting subtrees
- UNCLEAR: does the problem change whether cascading has been chosen or not??? <=== Please make this point clear!

R.

[TrickyTrix]

I can confirm that tree report many times doesn't generate any graph at all. It looks like it is random... I'll explain on one example in the picture below.

[geno]

Any update to this issue?
I'm running 0.8.8b with nectar 0.35a as well and experience the same issue: I have 1 report working fine with tree items but any new report refuses to work with tree items.
I did migrate to a new server and upgrade. Are there perhaps left overs in the database causing this? I had to recreate all my reports after migrating.

Regards,

[HenkeZan]

Hello!
Experiencing the same issue here with Cacti 0.8.8a and Nectar 0.35a.
Any news on investigation of this issue? Anyone of earlier posters found a solution? (Downgrade maybe?)

Thanks!

/HenkeZan

[geno]

Hello!
Experiencing the same issue here with Cacti 0.8.8a and Nectar 0.35a.
Any news on investigation of this issue? Anyone of earlier posters found a solution? (Downgrade maybe?)

Thanks!

/HenkeZan

The issue still remains.
Well, what I did was use the top branch in the report and this included all the graphs (a few I didn't want) and this works.

Regards,

[gianlucagiacometti]

Ok guys,
there are 2 problems connected to a wrong evaluation of cascade in nectar_functions.php.

1.
Function nectar_tree_has_graphs() needs anyway the branch id (line 628)

Code: Select all

---                             if (nectar_tree_has_graphs($item["tree_id"], 0, $nectar["user_id"], $item["graph_name_regexp"])) {
+++                             if (nectar_tree_has_graphs($item["tree_id"], $item["branch_id"], $nectar["user_id"], $item["graph_name_regexp"])) {
                                        $outstr .= nectar_expand_tree($nectar, $item, $output, $format_ok);
                                        }

2.
Function rtrim($order_key, '0') strips all zeros from the right. Since in the order_key field each tree level is given by three digits, the function fails to evaluate the right level when a level or sub-level is a mulple of 10.

example:
010 001
011 001
level 010 becomes 01 and not 010, so the item 011 001 is wrongly considered as child of the first one instead of a same level item.

We need to add zeros up to a sting length of 3.

So, a trivial patch can be (2 lines added around line 632):

Code: Select all

                                 if ($item['tree_cascade'] == 'on') {
                                        $order_key  = db_fetch_cell("SELECT order_key FROM graph_tree_items WHERE graph_tree_id=" . $item['tree_id'] . " AND id=" . $item['branch_id']);
                                        $corder_key = rtrim($order_key, '0');

// patch for right cascade
                                        if (strlen($corder_key) == 1) { $corder_key = $corder_key . "00"; }
                                        elseif (strlen($corder_key) == 2) { $corder_key = $corder_key . "0"; }
//

                                        $tree_branches = db_fetch_assoc("SELECT id FROM graph_tree_items WHERE graph_tree_id=" . $item['tree_id'] . " AND order_key LIKE '" . $corder_key . "%' AND order_key!='$order_key' ORDER BY order_key");
                                        if (sizeof($tree_branches)) {
                                          foreach ($tree_branches as $branch) {
                                                $item["branch_id"] = $branch["id"];
                                                if (nectar_tree_has_graphs($item["tree_id"], $item["branch_id"], $nectar["user_id"], $item["graph_name_regexp"])) {
                                                        $outstr .= nectar_expand_tree($nectar, $item, $output, $format_ok, true);
                                                }
                                          }
                                        }

all the best

G

[tbilan]

This solution worked great for me. Thanks!

To make it easier for people I made a patch file for both edits. Save this code in a file called 'nectarpatch' in the nectar directory and run 'patch nectar_funcations.php < nectarpatch'.

Code: Select all

--- backup/nectar_functions.php 2014-05-29 09:53:45.410574651 -0400
+++ nectar_functions.php        2014-05-29 09:58:14.500245813 -0400
@@ -623,14 +623,19 @@
                                /* start a new section */
                                $column = 0;
                        } elseif ($item['item_type'] == NECTAR_ITEM_TREE) {
-                               if (nectar_tree_has_graphs($item["tree_id"], 0, $nectar["user_id"], $item["graph_name_regexp"])) {
-                                       $outstr .= nectar_expand_tree($nectar, $item, $output, $format_ok);
-                               }
+                                if (nectar_tree_has_graphs($item["tree_id"], $item["branch_id"], $nectar["user_id"], $item["graph_name_regexp"])) {
+                                        $outstr .= nectar_expand_tree($nectar, $item, $output, $format_ok);
+                                        }
 
                                if ($item['tree_cascade'] == 'on') {
                                        $order_key  = db_fetch_cell("SELECT order_key FROM graph_tree_items WHERE graph_tree_id=" . $item['tree_id'] . " AND id=" . $item['branch_id']);
                                        $corder_key = rtrim($order_key, '0');
 
+
+                                        if (strlen($corder_key) == 1) { $corder_key = $corder_key . "00"; }
+                                        elseif (strlen($corder_key) == 2) { $corder_key = $corder_key . "0"; }
+
+
                                        $tree_branches = db_fetch_assoc("SELECT id FROM graph_tree_items WHERE graph_tree_id=" . $item['tree_id'] . " AND order_key LIKE '" . $corder_key . "%' AND order_key!='$order_key' ORDER BY order_key");
                                        if (sizeof($tree_branches)) {
                                        foreach ($tree_branches as $branch) {