weathermap 0.97c has a bug in editor.php

[icethink]

I found a bug in editor.php.It is on line number 794

Code: Select all

	case "delete_link":
		$map->ReadConfig($mapfile);

		$target = wm_editor_sanitize_name($_REQUEST['param']);
		$log = "delete link ".$target;

		if(isset($map->links[target])) {
		    unset($map->links[$target]);
		    
		    $map->WriteConfig($mapfile);
		}
		break;

($map->links[target])

When I click delete link, PHP throw a error. undefinded "target" ....

and I found that the code just like isset($map->links[target]) almost have this bug.
line number 727,760 also has this bug.

[Linegod]

http://www.cacti.net/bugs.php

[Howie]

This is fixed in latest, but replace [target] with [$target] in each place.