Repair corrupted graph-datasource associations

[shd]

When changing traffic graph template, I have deleted every item in that template. Cacti silently dropped all associations of graphs with datasources. I have immediately returned all items of graph template, but harm was already done. Every traffic graph was corrupted, traffic_in and traffic_out was set to "none" in each graph of this template.

I have searched through the forum, but didn't find any solution to this problem. It would be really a pain to associate each graph with corresponding datasources in 2000+ graphs or to restore from outdated backup, so I made quick and dirty fixer on top of repair_templates.php.

May be it will save a day for someone like me, so here it is.

It should be placed in cacti/cli directory and called like this:

Code: Select all

php repair_graphs.php --check --host-id=658 --data-template-id=41 --graph-template-id=2

--check - parameter to run only checking procedure. (Replace it with --execute to actually run the fix)
--recreate - Delete and recreate graph items (USE THIS OPTION WITH CAUTION! Data should not be deleted, but you may corrupt all your graphs if something go wrong)
--host-id - id of desired host, can be empty to check every graph in cacti database.
--data-template-id - id of data template, required, can be viewed at cacti/data_templates.php page.
--graph-template-id - id of graph template, required, can be viewed at cacti/graph_templates.php page.

For example, I used Interface - Traffic (bits/sec) graph template (id=2) with Interface - Traffic data template (id=41).

If you are familiar with SQL, you can add --show-sql parameter to see the SQL queries which will be executed.

Use with caution! There are not much error-checking!
Cacti database backup before execution is strongly advised. (db only, rra files are intact)

[wbo]

This is very useful for me - if it works. Thank you very much for your efforts. I am still wondering why it happened and if we are the only ones who had this problem.
I will come back and report if I could solve my problems with your fix.

[pparcell]

I was in the process of putting together the queries to do this exact same thing. Thanks so much for saving me the time of piecing together the queries .

[combellm]

Around two years later I did the same mistake....
My graphs only have 1 over 3 associations!
I lost almost everything with more than 1K graphs...

I tried to use this script but I don't have anything working...
Ijust have this line:

Code: Select all

-sh-3.2$ php repair_graphs.php --check --host-id=154 --data-template-id=41 --graph-template-id=2 --show-sql
NOTE: Performing Check of Graphs

-sh-3.2$

And nothing more without the --host-id=154 parameter...

CACTI version 0.8.8a

Thanks

[shd]

I tried to use this script but I don't have anything working...
Ijust have this line:

Code: Select all

-sh-3.2$ php repair_graphs.php --check --host-id=154 --data-template-id=41 --graph-template-id=2 --show-sql
NOTE: Performing Check of Graphs

-sh-3.2$

And nothing more without the --host-id=154 parameter...

Try checking your graph-template-id and data-template-id, choose it appropriately:

--data-template-id - id of data template, required, can be viewed at cacti/data_templates.php page.
--graph-template-id - id of graph template, required, can be viewed at cacti/graph_templates.php page.

[combellm]

I tried to use this script but I don't have anything working...
Ijust have this line:

Code: Select all

-sh-3.2$ php repair_graphs.php --check --host-id=154 --data-template-id=41 --graph-template-id=2 --show-sql
NOTE: Performing Check of Graphs

-sh-3.2$

And nothing more without the --host-id=154 parameter...

Try checking your graph-template-id and data-template-id, choose it appropriately:

--data-template-id - id of data template, required, can be viewed at cacti/data_templates.php page.
--graph-template-id - id of graph template, required, can be viewed at cacti/graph_templates.php page.

Yeah the ID's are correct!
I searched in the database because I didn't find it in the WEB interface...

[gandalf]

Code: Select all

	foreach($graph as $g) {
		$query = "SELECT * FROM graph_templates_item where local_graph_id=" . $g["id"];
		$graph_items = db_fetch_assoc($query);
		
		if (sizeof($graph_items)) {
			continue;
		}

I wonder, which specific case is tackled here. In case you find ANY graph_item, you skip the graph. So if only part of the graph is broken, this will be skipped. Do I understand that part of the code correctly?
R.

[gandalf]

Code: Select all

	foreach($graph as $g) {
		$query = "SELECT * FROM graph_templates_item where local_graph_id=" . $g["id"];
		$graph_items = db_fetch_assoc($query);
		
		if (sizeof($graph_items)) {
			continue;
		}

I wonder, which specific case is tackled here. In case you find ANY graph_item, you skip the graph. So if only part of the graph is broken, this will be skipped. Do I understand that part of the code correctly?
R.

BTB: yes, I modified the code a bit for more SQL debugging.
As you used the standard Cacti file header, you submit this to The Cacti Group under GPL V2, do you?

R.

[shd]

I wonder, which specific case is tackled here. In case you find ANY graph_item, you skip the graph. So if only part of the graph is broken, this will be skipped. Do I understand that part of the code correctly?

Yes, correct. I didn't have any graph items, so thought that's the way to search graphs for fixing.

As you used the standard Cacti file header, you submit this to The Cacti Group under GPL V2, do you?

True.

[gandalf]

I wonder, which specific case is tackled here. In case you find ANY graph_item, you skip the graph. So if only part of the graph is broken, this will be skipped. Do I understand that part of the code correctly?

Yes, correct. I didn't have any graph items, so thought that's the way to search graphs for fixing.

@combellm: I suppose that this is why it won't work for you. You still have "some" data source in right place. But I will work on this script to make it accept your case as well and submit it as an officially supported script to the Cacti codebase. I will honor shd as the original author, for sure.

R.

[combellm]

I wonder, which specific case is tackled here. In case you find ANY graph_item, you skip the graph. So if only part of the graph is broken, this will be skipped. Do I understand that part of the code correctly?

Yes, correct. I didn't have any graph items, so thought that's the way to search graphs for fixing.

@combellm: I suppose that this is why it won't work for you. You still have "some" data source in right place. But I will work on this script to make it accept your case as well and submit it as an officially supported script to the Cacti codebase. I will honor shd as the original author, for sure.

R.

Thanks
My case was due to something stupid I did! I repaired all my graphs by selecting again all datasources!
Took me 2 days!
Next time I will read everything before start something!

[ebitda]

Thank you for sharing your fix - it solved problems I had after using the 'Nexus' template

[shd]

New version: 0.3
Added graphs recreate option (i.e. delete graph items and then recreate them immediately). Comes handy if only a part of graph template is corrupted. But use it with caution, and please backup Cacti database beforehand. Data should not be deleted, but just in case.

[geno]

Just want to say thank you. I added some new fields in my template that I had forgotten.
The check or repair didn't work for me but the recreate function works perfectly!

[gandalf]

New version: 0.3
Added graphs recreate option (i.e. delete graph items and then recreate them immediately). Comes handy if only a part of graph template is corrupted. But use it with caution, and please backup Cacti database beforehand. Data should not be deleted, but just in case.

It seems, that you are faster than me. I was thinking about a different approach, but yours might be even simpler.
Thx for contributing!
R.