Boost 5.1 errors in code

[X-dark]

I had two different errors with Boost 5.1:

Code: Select all

BOOST: Poller[0] PROGERR: ERRNO:'8' TYPE:'Notice' MESSAGE:'Undefined variable: updates' IN FILE:'/cacti/plugins/boost/setup.php' LINE NO:'722'
BOOST: Poller[0] PROGERR: ERRNO:'8' TYPE:'Notice' MESSAGE:'Undefined index:  rrd_name' IN FILE:'/cacti/plugins/boost/setup.php' LINE NO:'1452'

I corrected them doing this (not really sure about the usefulness of "$updates" thus my first correction is likely incoherent:

Code: Select all

--- setup.php.orig      2012-03-27 15:45:53.000000000 +0200
+++ setup.php   2012-03-27 14:54:50.000000000 +0200
@@ -719,7 +719,7 @@

        /* get the information to populate into the rrd files */
        if (boost_check_correct_enabled()) {
-               $updates += boost_process_poller_output(TRUE, $local_data_id);
+               $updates = boost_process_poller_output(TRUE, $local_data_id);
        }

        /* restore original error handler */
@@ -1435,7 +1435,7 @@
        $ds_null      = array();
        $ds_nnull     = array();

-       $ds_names = db_fetch_assoc("SELECT data_source_name, rrd_path
+       $ds_names = db_fetch_assoc("SELECT data_source_name, rrd_path, rrd_name
                FROM data_template_rrd AS dtr
                INNER JOIN poller_item AS pi
                ON (pi.local_data_id=dtr.local_data_id

Is this a known bug? Should I submit a bug request?

[gandalf]

Both seem to be valid.
Please post a bug report and attach your code
R.

[X-dark]

Both seem to be valid.
Please post a bug report and attach your code
R.

Fine. Bug report is here: http://bugs.cacti.net/view.php?id=2200