thold 0.4.9-3 bugs: fixed (download patch here)

[computer_guru]

I noticed a bug where thold 0.4.9-3 would display associated notification list for a host incorrectly even though it was acutally associated with the correct list.


in file notify_lists.php

line 877

currently:
form_selectable_cell('<span style="color:red;font-weight:bold;">' . db_fetch_cell("SELECT name FROM plugin_notification_lists WHERE id=" . get_request_var_request('id')) . '</span>', $host['id']);

should be this to fix:
form_selectable_cell('<span style="color:red;font-weight:bold;">' . db_fetch_cell("SELECT name FROM plugin_notification_lists WHERE id=" . $host['thold_host_email']) . '</span>', $host['id']);

[computer_guru]

I found another bug in thold 0.4.9-3

if you have hosts that are recovering and hosts that are down in the same polling cycle, then the emails may be sent to the wrong notification lists. I have attached a fixed version of the file.

lines modified: 278 and 368

[update 3/14/12] - Uploaded a newer version with another minor bug fix for notification lists. (email would sometimes be sent to the correct notify list + the wrong notify list)

[update 3/22/12] - Uploaded a newer version again. My last fix solved the intended bug, but created a new bug. Both bugs are fixed now. (Emails going to global + notify list would only go to notify list)

[computer_guru]

File in post above has been updated.

[lightenup]

Thank you for this, I have been having this exact problem. Last night 87 hosts went down and I got a rude awakening at 2am for devices that I do not support!

[BSOD2600]

These have been logged under http://bugs.cacti.net/view.php?id=2312