Patch to fix reversed input/output colors for icon nink

Support questions about the Network Weather Map plugin

Moderators: Developers, Moderators

Post Reply
Deathwing00
Posts: 5
Joined: Wed Apr 28, 2010 6:41 am

Patch to fix reversed input/output colors for icon nink

Post by Deathwing00 »

I detected that the colors painted for the input and output values are inverted and do not match their values. Applying the following simple patch will fix the issue.

Code: Select all

--- WeatherMapNode.class.php.orig	2010-04-28 13:39:40.000000000 +0200
+++ WeatherMapNode.class.php	2010-04-28 13:39:45.000000000 +0200
@@ -363,8 +363,8 @@
                                         $size = $this->iconscalew;
                                         $quarter = $size/4;                             
                                         
-                                        $col1 = $this->colours[IN];
-                                        $col2 = $this->colours[OUT];
+                                        $col2 = $this->colours[IN];
+                                        $col1 = $this->colours[OUT];
                                         
                                         assert('!is_null($col1)');
                                         assert('!is_null($col2)');
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

Thanks!

I think you might be the only person using ninks... :-)
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
Deathwing00
Posts: 5
Joined: Wed Apr 28, 2010 6:41 am

Post by Deathwing00 »

Well, I better give good feedback then. Maybe this will tell others to use it as well. I really like the feature.
hawkeye1101
Posts: 1
Joined: Tue May 22, 2007 8:35 am

Re: Patch to fix reversed input/output colors for icon nink

Post by hawkeye1101 »

I just tried the 'nink' option, (which is really cool btw) and noticed the backwards values as well. Thanks for the fix!!! :D
Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests