Discovery Plugin - Bug report

General discussion about Plugins for Cacti

Moderators: Developers, Moderators

Post Reply
skirmish
Posts: 8
Joined: Wed Mar 31, 2010 10:26 pm

Discovery Plugin - Bug report

Post by skirmish »

In discovery where there is more than 1 page of results, the next page link is invalid. The link in my setup reads:

http://xx.xx.xx.xx/cacti/plugins/discov ... us=&page=2

host.php should be discover.php, there is no page called host.php.
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Discovery Plugin - Bug report

Post by gandalf »

This is which version of discovery, please?
R.
straderw
Posts: 2
Joined: Mon Mar 28, 2011 4:32 pm

Re: Discovery Plugin - Bug report

Post by straderw »

I am also having the same issue. I am running v1.1 it appears that in the discover.php file on line 323, 329, & 389 it clearly puts the a href as host.php.
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Discovery Plugin - Bug report

Post by gandalf »

IMHO, this has been corrected in current SVN.
Oops, don't know if that's publicly available.
Then, please replace those occurences with "discover.php".
The fix looks like

Code: Select all

<strong><< "; if ($page > 1) { $nav .= "<a class='linkOverDark' href='" . htmlspecialchars("discover.php?view&status=$status&os=$os&snmp=$snmp&ip=$ip&host=$host" . "&page=" . ($page-1)) . "'>"; } $nav .= "Previous"; if ($page > 1) { $nav .= "</a>"; } $nav .= "</strong>then (to prevent URL injection)
R.
straderw
Posts: 2
Joined: Mon Mar 28, 2011 4:32 pm

Re: Discovery Plugin - Bug report

Post by straderw »

Well my fix right now was to make a symbolic link called host.php and pointed it to the discover.php.

Any idea when the fix might be released?
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Re: Discovery Plugin - Bug report

Post by gandalf »

This is the sole right of the author. In this case, this is "cigamit".
R.
Post Reply

Who is online

Users browsing this forum: No registered users and 4 guests