autom8 and URL escaping with PIA 2.8 and Cacti 0.8.7g

General discussion about Plugins for Cacti

Moderators: Developers, Moderators

User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

autom8 and URL escaping with PIA 2.8 and Cacti 0.8.7g

Post by Howie »

After fiddling with patches for autom8 and pia2.8 it seems to mostly work, except that when I try to define which hosts to apply a rule to, I get a URL like:

http://192.168.0.28/plugins/autom8/auto ... tem_edit[b]&[/b]id=5&rule_type=1

It seems that something in either 'g' or pia2.8 is being too cautious with escaping?

Is there a fix? I have a new project that would really benefit from autom8 :-)
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

Update - it's only the 'Add' links. If I change one manually to be correct so I can add rules, then I can edit that rule with no problem. I think that puts the problem in the Cacti form-table drawing code.
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

And choosing 'Apply Autom8 rules' in the devices page leads to a confirmation page, and then a completely blank one. Nothing the apache or cacti logs...
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Post by gandalf »

Howie, did you try attached V035b6?
R.
Attachments
autom8-v0.35b6.tgz
(59.69 KiB) Downloaded 108 times
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

I used 0.33 from http://docs.cacti.net/plugins

I'll try this version.
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Post by gandalf »

I'm quite sure to have issues fixed in that version
R.
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

Where would I have found it?
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Post by gandalf »

In the v0.33 thread :(
R.
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

gandalf wrote:In the v0.33 thread :(
R.
Aha... obviously ;-)

Anyway, it does fix the problem so thank you! And thanks again for this plugin - it's a fantastic tool for being sure that all your devices graphs are configured the same way, and also for the tedious job of adding many switches at once.
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
TheWitness
Developer
Posts: 17062
Joined: Tue May 14, 2002 5:08 pm
Location: MI, USA
Contact:

Post by TheWitness »

So, the latest PIA 2.9 beta is good to go then?

Larry
True understanding begins only when we realize how little we truly understand...

Life is an adventure, let yours begin with Cacti!

Author of dozens of Cacti plugins and customization's. Advocate of LAMP, MariaDB, IBM Spectrum LSF and the world of batch. Creator of IBM Spectrum RTM, author of quite a bit of unpublished work and most of Cacti's bugs.
_________________
Official Cacti Documentation
GitHub Repository with Supported Plugins
Percona Device Packages (no support)
Interesting Device Packages


For those wondering, I'm still here, but lost in the shadows. Yearning for less bugs. Who want's a Cacti 1.3/2.0? Streams anyone?
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

TheWitness wrote:So, the latest PIA 2.9 beta is good to go then?

Larry
It works for me now :-)

I still don't know how to upgrade a plugin without losing my data, and the cactiuser.org wiki is spitting out binary crap instead of a homepage so there's effectively no documentation currently, but I suppose that's not actually a bug :-)
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Post by gandalf »

Howie wrote:I still don't know how to upgrade a plugin without losing my data,
??? I was under the assumtion, that all my plugins peform an auto-upgrade of table changes without loosing data. Very early versions were a bit picky, but this should all work now. So please tell me the exact issues you have.
and the cactiuser.org wiki is spitting out binary crap instead of a homepage so there's effectively no documentation currently, but I suppose that's not actually a bug :-)
Again, which link is failing? Were is documentation missing? I can post a pdf of course but I want to fix that issue at the root
R.
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

gandalf wrote:
Howie wrote:I still don't know how to upgrade a plugin without losing my data,
??? I was under the assumtion, that all my plugins peform an auto-upgrade of table changes without loosing data. Very early versions were a bit picky, but this should all work now. So please tell me the exact issues you have.
I expect it does, but it doesn't mention upgrades in the autom8 docs, and I couldn't see what the intended standard process might be because the PIA docs were unavailable. So I had no way to tell if it was correct. Perhaps one line in the README? "For upgrades, simply copy the new version over the top of the old one. All settings are preserved."

I think my own plugins are just as guilty of this, but now that some of these plugins have been around long enough to have many versions, perhaps it's a good idea to be clearer about an upgrade path.
gandalf wrote:
and the cactiuser.org wiki is spitting out binary crap instead of a homepage so there's effectively no documentation currently, but I suppose that's not actually a bug :-)
Again, which link is failing? Were is documentation missing? I can post a pdf of course but I want to fix that issue at the root
R.
Earlier today, any link on http://cactiusers.org/wiki/ was giving me a chunk of random characters, instead of a page. It's apparently fixed now.

However, the autom8 readme (and I guess many others) point the user to the Plugin Architecture documentation for more information. That page (http://cactiusers.org/wiki/PluginsInstall) describes how to install 1.x plugins, doesn't mention the plugin management page in Cacti, or anything that might need to be done for an upgrade. As I said, I suppose it's not actually a bug with Cacti, Autom8 or the PA.
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Post by gandalf »

Howie wrote:
gandalf wrote:
Howie wrote:I still don't know how to upgrade a plugin without losing my data,
??? I was under the assumtion, that all my plugins peform an auto-upgrade of table changes without loosing data. Very early versions were a bit picky, but this should all work now. So please tell me the exact issues you have.
I expect it does, but it doesn't mention upgrades in the autom8 docs, and I couldn't see what the intended standard process might be because the PIA docs were unavailable. So I had no way to tell if it was correct. Perhaps one line in the README? "For upgrades, simply copy the new version over the top of the old one. All settings are preserved."
Accepted
However, the autom8 readme (and I guess many others) point the user to the Plugin Architecture documentation for more information. That page (http://cactiusers.org/wiki/PluginsInstall) describes how to install 1.x plugins, doesn't mention the plugin management page in Cacti, or anything that might need to be done for an upgrade
Bad, indeed. I need more cycles for documentation ...
Anybody who's able to wrap up some lines is encouraged to place them into the dokuwiki.
R.
User avatar
Howie
Cacti Guru User
Posts: 5508
Joined: Thu Sep 16, 2004 5:53 am
Location: United Kingdom
Contact:

Post by Howie »

Howie wrote: Earlier today, any link on http://cactiusers.org/wiki/ was giving me a chunk of random characters, instead of a page. It's apparently fixed now.
Just to show I didn't dream it, it's doing it for me again! :-)

Attached is a screenshot of http://cactiusers.org/wiki/PluginArchitectureInstall
Attachments
crazy-wiki.png
crazy-wiki.png (469.37 KiB) Viewed 2864 times
Weathermap 0.98a is out! & QuickTree 1.0. Superlinks is over there now (and built-in to Cacti 1.x).
Some Other Cacti tweaks, including strip-graphs, icons and snmp/netflow stuff.
(Let me know if you have UK DevOps or Network Ops opportunities, too!)
Post Reply

Who is online

Users browsing this forum: No registered users and 3 guests