QuickTree - a shopping basket for graphs (0.2 released)

[Howie]

Hello,
It's really a great plugin.
I have a small issue : when i click on the tab quicktree i got redirected to the console tab.
I still have the normal quicktree display though, it's more a cosmetic problem than a real problem.
Any ideas on why it occurs ?

Cacti Version 0.8.7b
Cacti OS unix
SNMP Version net-snmp
RRDTool Version RRDTool 1.2.x

Regards,
Graz

No - I've never seen that before...

[rosskus]

Hey all,

Here is a small patch which adds the timespanning functionality from graphs_view.php into quicktree.php. This allows you to change the observable timespans of the graphs in the quicktree tab.

Ross Kusler

[michaelzhao]

I am getting broken icon image on the top after the patch.

showing:

X Start date selector
X End date selector
X Left
X Refresh selected time span
X Return to the default time span

I fixed this by removing the extra "/",
it was:
$config["url_path"];?>/images/calendar.gif'
changed to:
$config["url_path"];?>images/calendar.gif'

[rosskus]

Update to the patch... replaced <? with <?php in a few places too.

Ross Kusler

[alchie]

Am I so unlucky and the only one who has got no meta 'refresh' tag at page header? my quicktree never gets refreshed.

And by the way: I have the same issue with tab/console as 'grazog' does.

I have a small issue : when i click on the tab quicktree i got redirected to the console tab.
I still have the normal quicktree display though, it's more a cosmetic problem than a real problem.

[alchie]

Update to the patch... replaced <? with <?php in a few places too.

Ross Kusler

thanks. it works for me

[Enjanced]

Guys, does this work on 0.8.8b? I got it installed and it shows in config, but it won't show in tab, nor in Console menu, and the icon to add graphs don't show up either.

[Kreezer]

The Download-Link doesn't work. Error 404.

[Howie]

I upgraded the server to death last week, and then had to go out of town for a week. It will be resolved early next week (data is all fine, just an OS that doesn't boot). I have independent hosting for it now.

[mitchese]

First off, thanks for this great plugin!

We had a few issues with the installation in our environment, which may be related to our environment and how we're handling permissions. They are as follows, with solutions which we are using internally (read: probably subject to SQL injections, only implement if you trust your users!):

(1) If a user does not have permissions to change graph trees, it will still create the graph tree when they click on the "Save my QuickTree to a new graph tree" (or existing graph tree). The tree is first created, then the user is redirected to an error message that they cannot edit the newly created tree (though it is created). Workaround is when the save function is called, first check if the user has access to realm 4 (the "update trees" realm, I believe this is constant across all cacti installs, check your environment before making changes!)

Code: Select all

    case 'save':
        $username = db_fetch_cell("select username from user_auth where id=$user");
        //begin changes for permissions check
        // First check if the user is authorised to "Update Graph Trees", which corresponds to realm 4:
        $allowed=db_fetch_cell("select user_id from user_auth_realm where realm_id=4 and user_id=$user;");
        if ($allowed != $user) {
            print "<h1><font color=\"#ff0000\">Error: $username not Authorized for trees.  Please contact the service desk to request permission</font></h1>";
            exit(1);
        }
        // End changes for permissions check
        $new_tree_id = -1;
        $parent_id = 0;
 

(2) Our default policy is that users are denied access to trees, and then individual trees are enabled for the user. This meant that an authorised user would create a new tree but immediately be denied access (default policy). At the end of the save function (immediately before the redirect) in quicktree.php, create a permissions modification to enable the current user access to the newly created tree.

Code: Select all

        // user here is allowed to update graph trees; Next, check the default tree policy to see if it is allow (1) or deny (2)
        // if it is deny, we need to specifically add an entry in the user_auth_perms table to give them access to their new tree
        $tree_default_policy = db_fetch_cell("select policy_trees from user_auth where id=$user;");
        if ($tree_default_policy == 2) {
            // user is usually denied from trees; Allow them access to the new tree
             db_execute("replace into user_auth_perms(user_id, item_id, type) values('$user', '$new_tree_id', '2');");
        }
        //end changes

        header("Location: ../../tree.php?action=edit&id=" . $new_tree_id);
        break;

    case 'remove':
 

(3) Because users are blocked from seeing the entire list of trees in the system, when clicking "Add to existing tree" the window pops up with all known trees in the system instead of only those trees where the user has access. My fix checks the current user ID to see if they have limited access, and if so return only the trees where they have access. This fix will probably not work if you use the opposite management stragegy (users have access to everything EXCEPT the following trees...), but I suspect that's also broken in the plugin already.

Code: Select all

        print
            "<p>These are the graphs that you have added to your QuickTree. You can keep them here for as long as you like, o
r you can <a href='quicktree.php?action=save'>save them to a new Graph Tree</a> so you can keep them for later and work on so
mething new. (you can also <a id='qt_existing'>save them as a branch to an existing tree</a>) The idea is to collect together
 the graphs for a situation you are monitoring, as easily as possible.</p>";
        // Block users from seeing all trees which they don't have access to. Begin changes
        $tree_default_policy = db_fetch_cell("select policy_trees from user_auth where id=$user;");
        if ($tree_default_policy == 2) {
            // user is usually denied from trees; Allow them access to the new tree
            $SQL = "select g.id, g.name from graph_tree g where g.id in (select item_id from user_auth_perms where user_id=$u
ser) order by g.name";
        }
        else {
            $SQL = "select g.id, g.name from graph_tree g order by g.name";
        }
        // End changes
        $queryrows = db_fetch_assoc($SQL);
        if (sizeof($queryrows) > 0)
        {
            print "<div id='qt_treeselector'><h3>Add to which graph tree?</h3><form method='post' action='quicktree.php'><inp
ut name='action' type='hidden' value='save' /><select name='tree_id'>";