IP:PORT granularity in CLI scripts

[Big Networks]

Correctly, using the Web UI you can add hosts where 192.168.1.1:1000 and 192.168.1.1:2000 are considered two different devices.

This is not the case in the CLI scripts.

Why the discrepancy?

Wouldn't it make more sense for the two to behave in the same manner?

I've hacked the PHP code and written some Perl to side-step this discrepancy, but I really think this should be implemented in the CLI scripts.

Thanks for listening.

[rony]

That is definitely not right....

Please submit a bug at http://www.cacti.net/bugs.php

[Big Networks]

Reported - 0001534

Here's the diff of my hack of cli/add_device.php versus the original just to show what's going:

266,268c266,268
< db_execute("update host set hostname='$ip' where id=" . $hosts[$description]);
< echo "This host already exists in the database ($description) device-id: (" . $hosts[$description] . ")\n";
< exit(1);
---
> # db_execute("update host set hostname='$ip' where id=" . $hosts[$description]);
> # echo "This host already exists in the database ($description) device-id: (" . $hosts[$description] . ")\n";
> # exit(1);
277c277
< if (isset($addresses[$ip]) && $snmp_port == "161" ) {
---
> if (isset($addresses[$ip])) {
279,280c279,280
< echo "ERROR: This IP already exists in the database ($ip) device-id: (" . $addresses[$ip] . ")\n";
< exit(1);
---
> #echo "ERROR: This IP already exists in the database ($ip) device-id: (" . $addresses[$ip] . ")\n";
> #exit(1);

[Howie]

In fact in the web UI you can have two devices with the same IP AND port.

The cli will rename the existing device if you try to add a second one. It also doesn't tell you that it did that.