CaMM (Cacti Message Management) plugin v1.6.7 2010-08-26

[pthaynes]

gthe

Thanks again for your work on this plugin.

After thinking about it a bit more I am guessing using the template to select log items would have an impact on the performance of the database. I have added multiple "!=" clauses to my rules to de-select the hosts that I don't want to send emails for. It would be interesting to compare the impact of selecting based on template vs selecting based on multiple hosts. If the ability to select based on a template impacts all rules (even if you don't use that feature) I would suggest not using it (for example if you need to do a database join on the template id whether the rule selects using that field or not). If it only impacts users when they actually use that feature I would suggest adding the feature and a warning when people use it.

If you aren't able to change the rule processing to match based on the "mark" for a log entry I don't think changing the order of rule processing will make much difference. At the moment (correct me if I am wrong) the rules are processed in the order:
First: Rules that delete
Second: Rules that email
Third: Rules that mark

I wouldn't think you would want to change the order of the rules (I can't imagine wanting to send an email for a log entry and then deleting the entry immediately, nor wanting to mark a log entry only to have it deleted). The only thing that might change that is the order of "execute user funtion" rules, only because you might want to run some sql in a user function that might impact later processing for a rule (although I would think that would be rare).

Thanks again.

Regards,

Peter

[streaker69]

I just installed the new version tonight, and I've noticed a problem.

I had an issue with it loading up correctly in Firefox which I've resolved, but when I tried it in IE7, and it loads, but there's a slight visual issue as indicated in the image below.

[gthe]

The only thing that might change that is the order of "execute user funtion" rules, only because you might want to run some sql in a user function that might impact later processing for a rule (although I would think that would be rare).

Agree. Will be in settings.

If it only impacts users when they actually use that feature I would suggest adding the feature and a warning when people use it.

well, I will try

I just installed the new version tonight, and I've noticed a problem.

I had an issue with it loading up correctly in Firefox which I've resolved, but when I tried it in IE7, and it loads, but there's a slight visual issue as indicated in the image below.

thanks, fixed.

[gthe]

At the moment (correct me if I am wrong) the rules are processed in the order:
First: Rules that delete
Second: Rules that email
Third: Rules that mark

Wrong.
Do not confuse the order of rules and order of actions in the rule.
Rules selected fron db based on order

Code: Select all

ORDER BY `is_delete` DESC, `count_triggered` DESC;

ie - first rule with the greatest possible number of deleted records. Each rule can have multiple actions. They are executed in this order

user functions
mail
delete OR mark

So, I want to introduce 2 parameters:
Order of rules:

- default
- based on a new special field "order" in rule

Order of actions:

- default ("func","mail","del","mark")
-"mail","func","mark","del"
- any new

I think this will allow more flexibility to process records.

Do you agree?

[streaker69]

I think this is a minor visual error. If you set the default number of rows in settings to something other than 50 (I have mine set to 100) then the stats at the bottom displays the incorrect number of rows retrieved even though the select box shows the correct number per the settings.

If you use the select box, to change the number of rows, then it displays properly.

See the attached image.

[gthe]

The new version in the first post.

CAMM --- 1.6.3 ---2009-08-07

• - Switch to use ExtJS 2.3.0. before you updated on this with any previous version - you can completely remove directories: camm/images/default, camm/images/slate, camm/images/vista;
  - Added new config settings - [Rule order];
  - Added new config settings - [Action order in each rule];
  - Added new grid [Incorrect devices] in stats tab. Used to quickly determine the possible incorrect device. For example, if the device DEV1 and DEV2 belong to the same type of T1, and the device DEV1 sends a message, and the device DEV2 does not - then perhaps it is (DEV2) configured incorrectly ;
  - Fix IE visual bug in menu;

After updating the files, be sure to press CTRL + F5 to refresh your browser cache!

[gthe]

I think this is a minor visual error. If you set the default number of rows in settings to something other than 50 (I have mine set to 100) then the stats at the bottom displays the incorrect number of rows retrieved even though the select box shows the correct number per the settings.

If you use the select box, to change the number of rows, then it displays properly.

See the attached image.

Replace file from this archive (for 1.6.3 only):

[pthaynes]

The new version in the first post.

CAMM --- 1.6.3 ---2009-08-07

• - Switch to use ExtJS 2.3.0. before you updated on this with any previous version - you can completely remove directories: camm/images/default, camm/images/slate, camm/images/vista;
  - Added new config settings - [Rule order];
  - Added new config settings - [Action order in each rule];
  - Added new grid [Incorrect devices] in stats tab. Used to quickly determine the possible incorrect device. For example, if the device DEV1 and DEV2 belong to the same type of T1, and the device DEV1 sends a message, and the device DEV2 does not - then perhaps it is (DEV2) configured incorrectly ;
  - Fix IE visual bug in menu;

After updating the files, be sure to press CTRL + F5 to refresh your browser cache!

GTHE
The ordering for rule processing and action processing looks good. Sorry for not responding to your previous post about adding that functionality - I have been mostly offline for the last week or so.

Could you please explain the "Incorrect Device" tab a little more? To me the logic seems to be:
1. If a device of a device type has sent a syslog then highlight the "syslog cell" for all devices of that device type that have not sent a syslog.
2. If a device of a device type has sent an snmptrap then highlight the "snmptrap cell" for all devices of that device type that have not sent an snmptrap.

Is this correct?

Thanks for the update.

Regards,

Peter

[mcutting]

Gthe,

The Date/Time data appears to be missing after upgrade to 1.6.3 ??

Thanks

[gthe]

Could you please explain the "Incorrect Device" tab a little more? To me the logic seems to be:
1. If a device of a device type has sent a syslog then highlight the "syslog cell" for all devices of that device type that have not sent a syslog.
2. If a device of a device type has sent an snmptrap then highlight the "snmptrap cell" for all devices of that device type that have not sent an snmptrap.

Is this correct?

Yes.

Gthe,

The Date/Time data appears to be missing after upgrade to 1.6.3 ??

Thanks

it seems that yes, and this is strange, because it depends on the browser. It works in google chrome.

[mcutting]

Not working for me in either Firefox or Internet Explorer. Cache cleared on both occasions. V 1.6.2 doesn't have this issue.

Regds

[jpgr]

I'm having the same issue -- traptime not appearing in Firefox/IE for version 1.6.3. I can filter on traptime, so it looks like a presentation issue of some sort.

[gthe]

Yes, I have been working on a fix for this problem

[gthe]

Here is the fix: a new patch 3 more posts

[mcutting]

Confirmed as working