Feature request: Confirm to uninstall a plugin.

[browniebraun]

Hi Jimmy!

I'm currently working on ReportIt 0.7.0 and implemented the features of PIA 2.x last weekend. During a test of "plugin_reportit_uninstall" I realised that all data will be removed directly. Mmmhhh ... that's a little bit too fast.

So, how do you think about a confirmation box to avoid that?

I modified your function "update_show_current()" to test it with some lines of Java Script.

added:

Code: Select all

    ?>
    <script type="text/javascript">
    <!--

    function confirmation(plugin) {
    	var answer = confirm("Do you really want to uninstall " + plugin.toUpperCase() + " ?\nPlease note that individual settings, results and configurations of that plugin will get lost." )
    	if (answer){
            window.location = "plugins.php?mode=uninstall&id=" + plugin;
    	}
    }
    //-->
    </script>
    <?php

changed:

Code: Select all

					$links['uninstall'] = "<font color='blue' "
											. " onmouseover=\"this.style.textDecoration='underline';this.style.color='black';\" "
											. " onmouseout=\"this.style.textDecoration='none';this.style.color='blue'\" "
											. " onclick=confirmation('$plugin') style='cursor:pointer;'><b>Uninstall</b></font>";

Ok, the second part looks a little bit strange, but it's the only way I know how it will work with Opera too.

Best regards
-Andreas-

[Howie]

This is why I added only an empty function for _uninstall() too... far too easy to just remove all your data. I would cry for quite some time if I did that with thold.

Also, when the _check() is implemented, that should be able to return a message to the user about why the check failed.

[cigamit]

Ya, I will definitely add that. I am currently working on several new functions too that are needed for upgrades, updating / adding hooks, adding indexes, updating realm filenames, etc... I am also looking into an automatic version tracking, and a few things I noticed when writing a major upgrade for thold.

Lots and lots of work still needed. Keep the ideas coming so I can see the issues that everyone else is running into.


BTW, even with the uninstall hook blank, it will still wipe out all the data, as long as it used the plugin function to install the tables. It logs the tables and columns it added, so it knows what to remove when the time comes. The uninstall function is just incase there is anything extra, like temp files, that you want to remove.

I think ALOT of documentation is in order also.

[Howie]

BTW, even with the uninstall hook blank, it will still wipe out all the data, as long as it used the plugin function to install the tables. It logs the tables and columns it added, so it knows what to remove when the time comes. The uninstall function is just incase there is anything extra, like temp files, that you want to remove.

I think ALOT of documentation is in order also.

You can say that again. I didn't know there even was an api function to create tables.

I've accidentally uninstalled plugins a number of times recently, and *especially* since the blocks in the Plugin Management move around depending on whether plugins are enabled (thought you uninstalled the plugin you just disabled? nope, sorry). That makes having it also automatically delete all my data without warning seem like a bad idea. Perhaps at least the option to dump the tables to a file before dropping them would be useful...

[cigamit]

*especially* since the blocks in the Plugin Management move around depending on whether plugins are enabled

I will be fixing that next, its a pain now that the new version shows all plugins and everything is jumpy. I will just sort it by alphabetical.