Spine - Deadlock in ping.c

[peterostlin]

Hi all

I have found what I believe is a bug in ping.c (the spine source),
a potential deadlock when failing to resolve hostnames. The
affected spine process hang and fail to process the remaining
hosts when it encounters a bad hostname. Any unresolvable hostname
will trigger the problem.

In function 'init_sockaddr' (row 677) a mutex lock is taken and if
gethostbyname fail we try to take the lock again without releasing
it first.

Attached diff solves the issue for me. In it I also moved the
'Unknown host' logging to when we actually decide that the host is
unknown.


Cheers
Peter Östlin

[rony]

Please submit a bug to our bug tracker.

http://www.cacti.net/bugs.php

Also, please put in the bug what OS and compiler you are using.