[SOLVED] Lower limit and upper limit variable support

Anything that you think should be in Cacti.

Moderators: Developers, Moderators

Post Reply
llow
Cacti User
Posts: 170
Joined: Fri Oct 05, 2007 5:34 pm

[SOLVED] Lower limit and upper limit variable support

Post by llow »

It would be nice to be able to dynamicaly set the lower and upper limits through query or other variables.

The database structure would probably need to change lower_limit and upper_limit to a varchar(255).

I can work up a patch for 0.8.7 for this if anyone else thinks its a good idea.
User avatar
rony
Developer/Forum Admin
Posts: 6022
Joined: Mon Nov 17, 2003 6:35 pm
Location: Michigan, USA
Contact:

Post by rony »

Yep, it would be nice.

The only problem, and the reason it has yet to be implemented, is that updates to the RRDTool file are not made by Cacti once the file is created.

But to be honest, if you are going have dynamic variables, I would only want to apply them to the graph output.

Let's think of this, what if a max value where to be passed and applied to the data source, then the RRDTool file was updated, but this value was below past maximum values in the RRDtool file. Would those maximum values be retained or trimmed in the RRDtool file?

FYI, I want you to write this patch, I want to see what you come up with. :D But I want you to think about the above issues. :)

Thanks for reading my ramblings! 8)
[size=117][i][b]Tony Roman[/b][/i][/size]
[size=84][i]Experience is what causes a person to make new mistakes instead of old ones.[/i][/size]
[size=84][i]There are only 3 way to complete a project: Good, Fast or Cheap, pick two.[/i][/size]
[size=84][i]With age comes wisdom, what you choose to do with it determines whether or not you are wise.[/i][/size]
llow
Cacti User
Posts: 170
Joined: Fri Oct 05, 2007 5:34 pm

Post by llow »

I'll put something together. I am only planning on such functionality for the graphing portion as I would think most people would be using them for thresholds.
llow
Cacti User
Posts: 170
Joined: Fri Oct 05, 2007 5:34 pm

Post by llow »

Here is the patch.

Will need to increase varchar size as well to be useful...
ALTER TABLE graph_templates_graph MODIFY lower_limit VARCHAR(255);
ALTER TABLE graph_templates_graph MODIFY upper_limit VARCHAR(255);
Attachments
cacti-0.8.7-beta4-lowerupperlimit-variable.patch
(6.2 KiB) Downloaded 549 times
User avatar
rony
Developer/Forum Admin
Posts: 6022
Joined: Mon Nov 17, 2003 6:35 pm
Location: Michigan, USA
Contact:

Post by rony »

Please post a bug/feature for this, it easier for us to track.
[size=117][i][b]Tony Roman[/b][/i][/size]
[size=84][i]Experience is what causes a person to make new mistakes instead of old ones.[/i][/size]
[size=84][i]There are only 3 way to complete a project: Good, Fast or Cheap, pick two.[/i][/size]
[size=84][i]With age comes wisdom, what you choose to do with it determines whether or not you are wise.[/i][/size]
User avatar
gandalf
Developer
Posts: 22383
Joined: Thu Dec 02, 2004 2:46 am
Location: Muenster, Germany
Contact:

Post by gandalf »

Implemented in SVN, targeted release is 088
Reinhard
Post Reply

Who is online

Users browsing this forum: No registered users and 0 guests