[plugin settings 0.2] : not RFC 2821 compliant

[YoannQ]

I have update plugins/settings/include/mailer.php file

RFC Compliant for EHLO/HELLO

Syntax : EHLO myhostname (not EHLO SMTPhostname)

Replace on line 716

Code: Select all

/* Start SMTP conversation */
                        fputs($smtp_sock, "HELO " . $this->Config["Mail"]["SMTP_Host"] . "\r\n");

with

Code: Select all

/* Start SMTP conversation */
                        fputs($smtp_sock, "HELO " . $_SERVER['SERVER_NAME']. "\r\n");

RFC Compliant for MAIL FROM

Syntax : MAIL FROM: <user@domain.tld> (not MAIL FROM: user@domain.tld)

Replace on line +/- 756

Code: Select all

/* Send mail from */
fputs($smtp_sock, "MAIL FROM: " . $from . "\r\n");

with :

Code: Select all

/* Send mail from */
fputs($smtp_sock, "MAIL FROM: <" . $from . ">\r\n");

RFC Compliant for RCPT TO

Syntax : RCPT TO: <user@domain.tld> (not RCPT TO: user@domain.tld)

Replace on line 764

Code: Select all

/* Send rcpt to */
foreach ($to as $item) {
fputs($smtp_sock, "RCPT TO: " . $item . "\r\n");

with

Code: Select all

/* Send rcpt to */
foreach ($to as $item) {
fputs($smtp_sock, "RCPT TO: <" . $item . ">\r\n");

This is my contribution for today.

[gandalf]

Updated (with a slight modification) as Rev116 in SVN
Reinhard

[rony]

Um....

I will have to review these issues.

FYI, the "<" & ">" will break the way the mailer class works.

Opps on the HELO line... That would be a bug on my part..

[rony]

Um....

I will have to inspect and update...

"<" and ">" probably will not break it, unless the user puts in a formatted email.

[YoannQ]

Humggg ...

There a problem with EHLO command in my update when poller want send email.

in line 716

Code: Select all

/* Start SMTP conversation */
                        fputs($smtp_sock, "HELO " . $this->Config["Mail"]["SMTP_Host"] . "\r\n");

muste be replaced with

Code: Select all

/* Start SMTP conversation */
                        fputs($smtp_sock, "HELO " . $this->Config["Hostname"]. "\r\n");

In fact $_SERVER['SERVER_NAME'] not exist when php is running from cli.

Sorry.

[gandalf]

Yes. That was exactly my simple deviation from your first sugesstion. So no harm done
Reinhard

[rony]

Yep,

When I wrote it, I was testing from the CLI. So, that was not an variable that could be used, hence it was not.